From: Sergei Kornilov <sk@zsrv.org>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: =?utf-8?B?0J7Qu9C10LMg0KHQsNC80L7QudC70L7Qsg==?= <splarv@ya.ru>,
	pgsql-bugs@lists.postgresql.org,
	=?utf-8?B?w4FsdmFybyBIZXJyZXJh?= <alvherre@kurilemu.de>
In-Reply-To: <CAHGQGwF3tFP=oQgYHoS3h9TMeFbZwXc6+xdPTW8CkMV2TkjTmg@mail.gmail.com>
References: <202601301728.sfkizrto3t5i@alvherre.pgsql> <9b9341b0-942e-4d34-b94f-92bd918fad04@ya.ru>
	 <1317421770387925@cea5cfd9-50d3-4d85-a924-a7cc75f8f215> <CAHGQGwF3tFP=oQgYHoS3h9TMeFbZwXc6+xdPTW8CkMV2TkjTmg@mail.gmail.com>
Subject: Re: basic_archive lost archive_directory
MIME-Version: 1.0
Date: Mon, 09 Feb 2026 23:09:41 +0300
Message-Id: <20851770667781@4c74d20d-ac3b-4a50-93f1-fbe5aacb8285>
Content-Type: multipart/mixed;
	boundary="----==--bound.2086.28284c77-9ce1-4a25-90b9-44da86fc4e2a"
Archived-At: <https://www.postgresql.org/message-id/20851770667781%404c74d20d-ac3b-4a50-93f1-fbe5aacb8285>
Precedence: bulk


------==--bound.2086.28284c77-9ce1-4a25-90b9-44da86fc4e2a
Content-Transfer-Encoding: 7bit
Content-Type: text/plain

Hello!

> In your patch, only the existence check is moved to basic_archive_configured().
> Would it also make sense to move the filename length check there? If so,
> we could potentially remove the check_archive_directory GUC check hook entirely.

Indeed.

I'm not sure, do I need to keep the check_archive_directory declaration for backport branches? I will split the patch into two parts.

regards, Sergei
------==--bound.2086.28284c77-9ce1-4a25-90b9-44da86fc4e2a
Content-Disposition: attachment;
	filename="001-bug_basic_archive_lost_archive_directory.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
	name="001-bug_basic_archive_lost_archive_directory.patch"

ZGlmZiAtLWdpdCBhL2NvbnRyaWIvYmFzaWNfYXJjaGl2ZS9iYXNpY19hcmNoaXZlLmMgYi9jb250
cmliL2Jhc2ljX2FyY2hpdmUvYmFzaWNfYXJjaGl2ZS5jCmluZGV4IDZjN2Y5ODVkNDhiLi4yNzNm
ZDU0ZGM2ZCAxMDA2NDQKLS0tIGEvY29udHJpYi9iYXNpY19hcmNoaXZlL2Jhc2ljX2FyY2hpdmUu
YworKysgYi9jb250cmliL2Jhc2ljX2FyY2hpdmUvYmFzaWNfYXJjaGl2ZS5jCkBAIC05NCw1NyAr
OTQsNDcgQEAgX1BHX2FyY2hpdmVfbW9kdWxlX2luaXQodm9pZCkKICAqLwogc3RhdGljIGJvb2wK
IGNoZWNrX2FyY2hpdmVfZGlyZWN0b3J5KGNoYXIgKipuZXd2YWwsIHZvaWQgKipleHRyYSwgR3Vj
U291cmNlIHNvdXJjZSkKK3sKKwlyZXR1cm4gdHJ1ZTsKK30KKworLyoKKyAqIGJhc2ljX2FyY2hp
dmVfY29uZmlndXJlZAorICoKKyAqIENoZWNrcyB0aGF0IGFyY2hpdmVfZGlyZWN0b3J5IGlzIG5v
dCBibGFuayBhbmQgZXhpc3RzLgorICovCitzdGF0aWMgYm9vbAorYmFzaWNfYXJjaGl2ZV9jb25m
aWd1cmVkKEFyY2hpdmVNb2R1bGVTdGF0ZSAqc3RhdGUpCiB7CiAJc3RydWN0IHN0YXQgc3Q7CiAK
LQkvKgotCSAqIFRoZSBkZWZhdWx0IHZhbHVlIGlzIGFuIGVtcHR5IHN0cmluZywgc28gd2UgaGF2
ZSB0byBhY2NlcHQgdGhhdCB2YWx1ZS4KLQkgKiBPdXIgY2hlY2tfY29uZmlndXJlZCBjYWxsYmFj
ayBhbHNvIGNoZWNrcyBmb3IgdGhpcyBhbmQgcHJldmVudHMKLQkgKiBhcmNoaXZpbmcgZnJvbSBw
cm9jZWVkaW5nIGlmIGl0IGlzIHN0aWxsIGVtcHR5LgotCSAqLwotCWlmICgqbmV3dmFsID09IE5V
TEwgfHwgKm5ld3ZhbFswXSA9PSAnXDAnKQotCQlyZXR1cm4gdHJ1ZTsKKwlpZiAoYXJjaGl2ZV9k
aXJlY3RvcnkgPT0gTlVMTCB8fCBhcmNoaXZlX2RpcmVjdG9yeVswXSA9PSAnXDAnKQorCXsKKwkJ
YXJjaF9tb2R1bGVfY2hlY2tfZXJyZGV0YWlsKCIlcyBpcyBub3Qgc2V0LiIsCisJCQkJCQkJCSJi
YXNpY19hcmNoaXZlLmFyY2hpdmVfZGlyZWN0b3J5Iik7CisKKwkJcmV0dXJuIGZhbHNlOworCX0K
IAogCS8qCiAJICogTWFrZSBzdXJlIHRoZSBmaWxlIHBhdGhzIHdvbid0IGJlIHRvbyBsb25nLiAg
VGhlIGRvY3MgaW5kaWNhdGUgdGhhdCB0aGUKIAkgKiBmaWxlIG5hbWVzIHRvIGJlIGFyY2hpdmVk
IGNhbiBiZSB1cCB0byA2NCBjaGFyYWN0ZXJzIGxvbmcuCiAJICovCi0JaWYgKHN0cmxlbigqbmV3
dmFsKSArIDY0ICsgMiA+PSBNQVhQR1BBVEgpCisJaWYgKHN0cmxlbihhcmNoaXZlX2RpcmVjdG9y
eSkgKyA2NCArIDIgPj0gTUFYUEdQQVRIKQogCXsKLQkJR1VDX2NoZWNrX2VycmRldGFpbCgiQXJj
aGl2ZSBkaXJlY3RvcnkgdG9vIGxvbmcuIik7CisJCWFyY2hfbW9kdWxlX2NoZWNrX2VycmRldGFp
bCgiQXJjaGl2ZSBkaXJlY3RvcnkgdG9vIGxvbmcuIik7CiAJCXJldHVybiBmYWxzZTsKIAl9CiAK
LQkvKgotCSAqIERvIGEgYmFzaWMgc2FuaXR5IGNoZWNrIHRoYXQgdGhlIHNwZWNpZmllZCBhcmNo
aXZlIGRpcmVjdG9yeSBleGlzdHMuIEl0Ci0JICogY291bGQgYmUgcmVtb3ZlZCBhdCBzb21lIHBv
aW50IGluIHRoZSBmdXR1cmUsIHNvIHdlIHN0aWxsIG5lZWQgdG8gYmUKLQkgKiBwcmVwYXJlZCBm
b3IgaXQgbm90IHRvIGV4aXN0IGluIHRoZSBhY3R1YWwgYXJjaGl2aW5nIGxvZ2ljLgotCSAqLwot
CWlmIChzdGF0KCpuZXd2YWwsICZzdCkgIT0gMCB8fCAhU19JU0RJUihzdC5zdF9tb2RlKSkKKwlp
ZiAoc3RhdChhcmNoaXZlX2RpcmVjdG9yeSwgJnN0KSAhPSAwIHx8ICFTX0lTRElSKHN0LnN0X21v
ZGUpKQogCXsKLQkJR1VDX2NoZWNrX2VycmRldGFpbCgiU3BlY2lmaWVkIGFyY2hpdmUgZGlyZWN0
b3J5IGRvZXMgbm90IGV4aXN0LiIpOworCQlhcmNoX21vZHVsZV9jaGVja19lcnJkZXRhaWwoIlNw
ZWNpZmllZCBhcmNoaXZlIGRpcmVjdG9yeSBkb2VzIG5vdCBleGlzdC4iKTsKIAkJcmV0dXJuIGZh
bHNlOwogCX0KIAogCXJldHVybiB0cnVlOwogfQogCi0vKgotICogYmFzaWNfYXJjaGl2ZV9jb25m
aWd1cmVkCi0gKgotICogQ2hlY2tzIHRoYXQgYXJjaGl2ZV9kaXJlY3RvcnkgaXMgbm90IGJsYW5r
LgotICovCi1zdGF0aWMgYm9vbAotYmFzaWNfYXJjaGl2ZV9jb25maWd1cmVkKEFyY2hpdmVNb2R1
bGVTdGF0ZSAqc3RhdGUpCi17Ci0JaWYgKGFyY2hpdmVfZGlyZWN0b3J5ICE9IE5VTEwgJiYgYXJj
aGl2ZV9kaXJlY3RvcnlbMF0gIT0gJ1wwJykKLQkJcmV0dXJuIHRydWU7Ci0KLQlhcmNoX21vZHVs
ZV9jaGVja19lcnJkZXRhaWwoIiVzIGlzIG5vdCBzZXQuIiwKLQkJCQkJCQkJImJhc2ljX2FyY2hp
dmUuYXJjaGl2ZV9kaXJlY3RvcnkiKTsKLQlyZXR1cm4gZmFsc2U7Ci19Ci0KIC8qCiAgKiBiYXNp
Y19hcmNoaXZlX2ZpbGUKICAqCg==
------==--bound.2086.28284c77-9ce1-4a25-90b9-44da86fc4e2a
Content-Disposition: attachment;
	filename="002-basic_archive_remove_check_archive_directory.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
	name="002-basic_archive_remove_check_archive_directory.patch"

ZGlmZiAtLWdpdCBhL2NvbnRyaWIvYmFzaWNfYXJjaGl2ZS9iYXNpY19hcmNoaXZlLmMgYi9jb250
cmliL2Jhc2ljX2FyY2hpdmUvYmFzaWNfYXJjaGl2ZS5jCmluZGV4IDI3M2ZkNTRkYzZkLi5iNTdm
ZDRjODlkYyAxMDA2NDQKLS0tIGEvY29udHJpYi9iYXNpY19hcmNoaXZlL2Jhc2ljX2FyY2hpdmUu
YworKysgYi9jb250cmliL2Jhc2ljX2FyY2hpdmUvYmFzaWNfYXJjaGl2ZS5jCkBAIC00Niw3ICs0
Niw2IEBAIHN0YXRpYyBjaGFyICphcmNoaXZlX2RpcmVjdG9yeSA9IE5VTEw7CiAKIHN0YXRpYyBi
b29sIGJhc2ljX2FyY2hpdmVfY29uZmlndXJlZChBcmNoaXZlTW9kdWxlU3RhdGUgKnN0YXRlKTsK
IHN0YXRpYyBib29sIGJhc2ljX2FyY2hpdmVfZmlsZShBcmNoaXZlTW9kdWxlU3RhdGUgKnN0YXRl
LCBjb25zdCBjaGFyICpmaWxlLCBjb25zdCBjaGFyICpwYXRoKTsKLXN0YXRpYyBib29sIGNoZWNr
X2FyY2hpdmVfZGlyZWN0b3J5KGNoYXIgKipuZXd2YWwsIHZvaWQgKipleHRyYSwgR3VjU291cmNl
IHNvdXJjZSk7CiBzdGF0aWMgYm9vbCBjb21wYXJlX2ZpbGVzKGNvbnN0IGNoYXIgKmZpbGUxLCBj
b25zdCBjaGFyICpmaWxlMik7CiAKIHN0YXRpYyBjb25zdCBBcmNoaXZlTW9kdWxlQ2FsbGJhY2tz
IGJhc2ljX2FyY2hpdmVfY2FsbGJhY2tzID0gewpAQCAtNzEsNyArNzAsNyBAQCBfUEdfaW5pdCh2
b2lkKQogCQkJCQkJCSAgICIiLAogCQkJCQkJCSAgIFBHQ19TSUdIVVAsCiAJCQkJCQkJICAgMCwK
LQkJCQkJCQkgICBjaGVja19hcmNoaXZlX2RpcmVjdG9yeSwgTlVMTCwgTlVMTCk7CisJCQkJCQkJ
ICAgTlVMTCwgTlVMTCwgTlVMTCk7CiAKIAlNYXJrR1VDUHJlZml4UmVzZXJ2ZWQoImJhc2ljX2Fy
Y2hpdmUiKTsKIH0KQEAgLTg3LDE3ICs4Niw2IEBAIF9QR19hcmNoaXZlX21vZHVsZV9pbml0KHZv
aWQpCiAJcmV0dXJuICZiYXNpY19hcmNoaXZlX2NhbGxiYWNrczsKIH0KIAotLyoKLSAqIGNoZWNr
X2FyY2hpdmVfZGlyZWN0b3J5Ci0gKgotICogQ2hlY2tzIHRoYXQgdGhlIHByb3ZpZGVkIGFyY2hp
dmUgZGlyZWN0b3J5IGV4aXN0cy4KLSAqLwotc3RhdGljIGJvb2wKLWNoZWNrX2FyY2hpdmVfZGly
ZWN0b3J5KGNoYXIgKipuZXd2YWwsIHZvaWQgKipleHRyYSwgR3VjU291cmNlIHNvdXJjZSkKLXsK
LQlyZXR1cm4gdHJ1ZTsKLX0KLQogLyoKICAqIGJhc2ljX2FyY2hpdmVfY29uZmlndXJlZAogICoK

------==--bound.2086.28284c77-9ce1-4a25-90b9-44da86fc4e2a--