From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
cc: Marcos David <mdavid@palantir.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16106: Patch - Radius secrets always gets lowercased
In-reply-to: 
 <CABUevEwbPJJ=5M2pTVwME5mVbH=_GrGoeg8Eo_NTj8mRMVsBEA@mail.gmail.com>
References: <16106-7d319e4295d08e70@postgresql.org>
 <19993.1573503787@sss.pgh.pa.us>
 <BC05948D-9509-4F30-A350-7E2C36570CF1@palantir.com>
 <7942.1573576426@sss.pgh.pa.us>
 <CABUevEwbPJJ=5M2pTVwME5mVbH=_GrGoeg8Eo_NTj8mRMVsBEA@mail.gmail.com>
Comments: In-reply-to Magnus Hagander <magnus@hagander.net>
	message dated "Tue, 12 Nov 2019 10:45:13 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20965.1573582034.1@sss.pgh.pa.us>
Date: Tue, 12 Nov 2019 13:07:14 -0500
Message-ID: <20966.1573582034@sss.pgh.pa.us>
Precedence: bulk

Magnus Hagander <magnus@hagander.net> writes:
> On Tue, Nov 12, 2019 at 10:33 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> However, while you can defeat the downcasing that way, you can't
>> bypass the truncation to NAMEDATALEN.  So it's arguably broken

> I believe the RADIUS standard doesn't actually specify the length of the
> key, so different implementations have different limits. For example
> freeradius has 48 characters, cisco has 63.

I agree that it's somewhat unlikely that truncation at 63 bytes would
matter in practical use-cases, for any of these four parameters.
Still, it's not a good thing, and the fix is trivial given that we
have a suitable function at hand already.

I'll try to improve the docs while I'm at it.

			regards, tom lane