Content-Type: multipart/alternative;
 boundary="------------tzieZZ0xYrn0KOPQEy9ebWXa"
Message-ID: <20a57c76-7aaf-a641-add3-147541a4dccf@gmail.com>
Date: Fri, 13 Sep 2024 21:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: BUG #18616: Long-running hash index build can not be interrupted
Content-Language: en-US
To: Pavel Borisov <pashkin.elfe@gmail.com>
References: <18616-acbb9e5caf41e964@postgresql.org>
 <CALT9ZEF8uLBizGLFEQArNv1t6aoQnjKuo04yEQfyup9nodj6Bg@mail.gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
In-Reply-To: 
 <CALT9ZEF8uLBizGLFEQArNv1t6aoQnjKuo04yEQfyup9nodj6Bg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20a57c76-7aaf-a641-add3-147541a4dccf%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------tzieZZ0xYrn0KOPQEy9ebWXa
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Pavel,

13.09.2024 17:51, Pavel Borisov wrote:
>
>
>     Reproduced on all supported versions.
>
> I was unable to reproduce it on my machine with these settings. Tried statement timeouts 30-120s. Index build appears 
> to be in interruptible phase on my system.
> But could you check in your environment with the following patch?
>

Thank you for paying attention to this!

Yes, the patch works for me. The query is interrupted as expected.
But I wonder, why don't you the see same?

Could you please show the server log, with the following change applied and
log_statement = 'all'
backtrace_functions = 'ProcessInterrupts'
?

--- a/src/backend/access/hash/hashsort.c
+++ b/src/backend/access/hash/hashsort.c
@@ -125,6 +125,7 @@ _h_indexbuild(HSpool *hspool, Relation heapRel)
      uint32      hashkey = 0;
  #endif

+elog(LOG, "_h_indexbuild() start");
      tuplesort_performsort(hspool->sortstate);

      while ((itup = tuplesort_getindextuple(hspool->sortstate, true)) != NULL)
@@ -151,4 +152,5 @@ _h_indexbuild(HSpool *hspool, Relation heapRel)
pgstat_progress_update_param(PROGRESS_CREATEIDX_TUPLES_DONE,
                                       ++tups_done);
      }
+elog(LOG, "_h_indexbuild() end; tups_done: %ld", tups_done);
  }

Best regards,
Alexander
--------------tzieZZ0xYrn0KOPQEy9ebWXa
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hi Pavel,<br>
      <br>
      13.09.2024 17:51, Pavel Borisov wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CALT9ZEF8uLBizGLFEQArNv1t6aoQnjKuo04yEQfyup9nodj6Bg@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr"><br>
        <div class="gmail_quote">
          <blockquote class="gmail_quote" style="margin:0px 0px 0px
            0.8ex;border-left:1px solid
            rgb(204,204,204);padding-left:1ex">
            <br>
            Reproduced on all supported versions.<br>
          </blockquote>
          <div>I was unable to reproduce it on my machine with these
            settings. Tried statement timeouts 30-120s. Index build
            appears to be in interruptible phase on my system.</div>
          <div>But could you check in your environment with the
            following patch?</div>
          <div><br>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    Thank you for paying attention to this!<br>
    <br>
    Yes, the patch works for me. The query is interrupted as expected.<br>
    But I wonder, why don't you the see same?<br>
    <br>
    Could you please show the server log, with the following change
    applied and<br>
    log_statement = 'all'<br>
    backtrace_functions = 'ProcessInterrupts'<br>
    ?<br>
    <br>
    --- a/src/backend/access/hash/hashsort.c<br>
    +++ b/src/backend/access/hash/hashsort.c<br>
    @@ -125,6 +125,7 @@ _h_indexbuild(HSpool *hspool, Relation heapRel)<br>
         uint32      hashkey = 0;<br>
     #endif<br>
     <br>
    +elog(LOG, "_h_indexbuild() start");<br>
         tuplesort_performsort(hspool-&gt;sortstate);<br>
     <br>
         while ((itup = tuplesort_getindextuple(hspool-&gt;sortstate,
    true)) != NULL)<br>
    @@ -151,4 +152,5 @@ _h_indexbuild(HSpool *hspool, Relation heapRel)<br>
            
    pgstat_progress_update_param(PROGRESS_CREATEIDX_TUPLES_DONE,<br>
                                          ++tups_done);<br>
         }<br>
    +elog(LOG, "_h_indexbuild() end; tups_done: %ld", tups_done);<br>
     }<br>
    <br>
    Best regards,<br>
    Alexander<br>
  </body>
</html>

--------------tzieZZ0xYrn0KOPQEy9ebWXa--