Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xMX21-000000024YP-1IaC for pgsql-bugs@arkaria.postgresql.org; Thu, 29 Oct 2026 20:47:29 +0000 Received: from localhost ([127.0.0.1]:40766 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xMX20-00000006AHH-3YBi for pgsql-bugs@arkaria.postgresql.org; Thu, 29 Oct 2026 20:47:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:50878) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xMX20-00000006AH9-2Gx9 for pgsql-bugs@lists.postgresql.org; Thu, 29 Oct 2026 20:47:28 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xMX1y-00000001e09-1Qc8 for pgsql-bugs@lists.postgresql.org; Thu, 29 Oct 2026 20:47:28 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 69TKlI6T2114662; Thu, 29 Oct 2026 16:47:18 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 sss.pgh.pa.us 69TKlI6T2114662 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sss.pgh.pa.us; s=default; t=1793306838; bh=DsovyFSkZlPO1GUrzyeF43Blzo9H31f+PiCQuAj/yMo=; h=From:To:cc:Subject:In-reply-to:References:Date:From; b=nUVqDLrwvioub0CIJOuChqkQ/WbMVB6/g/6Ldkl94PRGcwOxpkJEnisgJ5T6jyuKk 3LNmMbAdzL3dhS8qDgdv+Ffdk4COEx52MebIuYwHqNNuYPbElu3MvAr/4rbVztKyuS JmkAE5/sLdoysBqZNBzm/prDPtoqPmSvCjTbtKmU= From: Tom Lane To: Matt Carter cc: Andres Freund , "pgsql-bugs@lists.postgresql.org" Subject: Re: BUG #19411: libpq 16.x exhibits a memory leak when connections are repeatedly created and destroyed In-reply-to: References: <19411-0440c8897a04b638@postgresql.org> <1702505.1771347709@sss.pgh.pa.us> <1881734.1771354069@sss.pgh.pa.us> <6xylkfh6idnx7ujhfhyoxku3v67ygoeve4yt7z2ytc65vzwvcv@z2sj5jnamhbe> Comments: In-reply-to Matt Carter message dated "Thu, 29 Oct 2026 18:40:10 -0000" MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0" Content-ID: <2114651.1793306824.0@sss.pgh.pa.us> Date: Thu, 29 Oct 2026 16:47:18 -0400 Message-ID: <2114661.1793306838@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk ------- =_aaaaaaaaaa0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2114651.1793306824.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Matt Carter writes: > Your suspicion was right, and I'm sorry for pointing at psycopg2 earlier= . The leak is in libpq, and it needs GSSAPI *authentication*. Every connec= tion to my server authenticates via "gss" in pg_hba.conf. My gssencmode=3D= disable runs only turned off GSS encryption, so none of my tests ever remo= ved it. > pg_GSS_continue() runs once per GSS round trip, and Kerberos with mutual= authentication takes two. On every call it does > /* Only try to acquire credentials if GSS delegation isn't disab= led. */ > if (!pg_GSS_have_cred_cache(&conn->gcred)) > conn->gcred =3D GSS_C_NO_CREDENTIAL; > pg_GSS_have_cred_cache() calls gss_acquire_cred() and stores the result = in *cred_out. It doesn't release the credential that is already there. Ooops. It looks like this isn't the only place that makes that mistake: select_next_encryption_method seems at risk too, or at least if it's not, that's because of caller logic not anything it's doing itself. I think that's partially because pg_GSS_have_cred_cache is poorly named: it sounds like a status test not an action, and its API is just bizarre. I propose changing its name altogether, as attached. regards, tom lane ------- =_aaaaaaaaaa0 Content-Type: text/x-diff; name="fix-gss-credentials-leak.patch"; charset="us-ascii" Content-ID: <2114651.1793306824.2@sss.pgh.pa.us> Content-Description: fix-gss-credentials-leak.patch Content-Transfer-Encoding: quoted-printable diff --git a/src/interfaces/libpq/fe-auth.c b/src/interfaces/libpq/fe-auth= .c index e3bddf91203..fe9756da691 100644 --- a/src/interfaces/libpq/fe-auth.c +++ b/src/interfaces/libpq/fe-auth.c @@ -101,9 +101,9 @@ pg_GSS_continue(PGconn *conn, int payloadlen) if (conn->Pfdebug) pqTraceOutputMessage(conn, conn->inBuffer + conn->inStart, false); = - /* Only try to acquire credentials if GSS delegation isn't disabled. */ - if (!pg_GSS_have_cred_cache(&conn->gcred)) - conn->gcred =3D GSS_C_NO_CREDENTIAL; + /* try to acquire credentials if we didn't already */ + if (conn->gcred =3D=3D GSS_C_NO_CREDENTIAL) + conn->gcred =3D pg_GSS_get_cred_cache(); = if (conn->gssdelegation && conn->gssdelegation[0] =3D=3D '1') gss_flags |=3D GSS_C_DELEG_FLAG; diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-c= onnect.c index 811cb0f2a50..9e17a8f1c6f 100644 --- a/src/interfaces/libpq/fe-connect.c +++ b/src/interfaces/libpq/fe-connect.c @@ -3281,7 +3281,8 @@ keep_going: /* We will come back to here until = there is } if (conn->gcred =3D=3D GSS_C_NO_CREDENTIAL) { - if (!pg_GSS_have_cred_cache(&conn->gcred)) + conn->gcred =3D pg_GSS_get_cred_cache(); + if (conn->gcred =3D=3D GSS_C_NO_CREDENTIAL) { libpq_append_conn_error(conn, "GSSAPI encryption required but no credential cache"); @@ -4847,15 +4848,16 @@ select_next_encryption_method(PGconn *conn, bool h= ave_valid_connection) if ((remaining_methods & ENC_GSSAPI) !=3D 0) { /* - * If GSSAPI encryption is enabled, then call pg_GSS_have_cred_cache() - * which will return true if we can acquire credentials (and give us a - * handle to use in conn->gcred), and then send a packet to the server + * If GSSAPI encryption is enabled, then call pg_GSS_get_cred_cache() + * to try to acquire credentials, and then send a packet to the server * asking for GSSAPI Encryption (and skip past SSL negotiation and * regular startup below). */ if (!conn->gctx) { - if (!pg_GSS_have_cred_cache(&conn->gcred)) + if (conn->gcred =3D=3D GSS_C_NO_CREDENTIAL) + conn->gcred =3D pg_GSS_get_cred_cache(); + if (conn->gcred =3D=3D GSS_C_NO_CREDENTIAL) { conn->allowed_enc_methods &=3D ~ENC_GSSAPI; remaining_methods &=3D ~ENC_GSSAPI; @@ -5020,6 +5022,10 @@ pqMakeEmptyPGconn(void) conn->altsock =3D PGINVALID_SOCKET; conn->Pfdebug =3D NULL; = +#ifdef ENABLE_GSS + conn->gcred =3D GSS_C_NO_CREDENTIAL; /* let's not assume this is 0 */ +#endif + /* * We try to send at least 8K at a time, which is the usual size of pipe * buffers on Unix systems. That way, when we are sending a large amoun= t diff --git a/src/interfaces/libpq/fe-gssapi-common.c b/src/interfaces/libp= q/fe-gssapi-common.c index e7776fe76e7..c23819a219c 100644 --- a/src/interfaces/libpq/fe-gssapi-common.c +++ b/src/interfaces/libpq/fe-gssapi-common.c @@ -55,10 +55,11 @@ pg_GSS_error(const char *mprefix, PGconn *conn, } = /* - * Check if we can acquire credentials at all (and yield them if so). + * Attempt to acquire credentials, and return the token if successful. + * Return GSS_C_NO_CREDENTIAL if not. */ -bool -pg_GSS_have_cred_cache(gss_cred_id_t *cred_out) +gss_cred_id_t +pg_GSS_get_cred_cache(void) { OM_uint32 major, minor; @@ -67,12 +68,8 @@ pg_GSS_have_cred_cache(gss_cred_id_t *cred_out) major =3D gss_acquire_cred(&minor, GSS_C_NO_NAME, 0, GSS_C_NO_OID_SET, GSS_C_INITIATE, &cred, NULL, NULL); if (major !=3D GSS_S_COMPLETE) - { - *cred_out =3D NULL; - return false; - } - *cred_out =3D cred; - return true; + return GSS_C_NO_CREDENTIAL; + return cred; } = /* diff --git a/src/interfaces/libpq/fe-gssapi-common.h b/src/interfaces/libp= q/fe-gssapi-common.h index f89d9e071e8..769e9f5ae91 100644 --- a/src/interfaces/libpq/fe-gssapi-common.h +++ b/src/interfaces/libpq/fe-gssapi-common.h @@ -20,7 +20,7 @@ = void pg_GSS_error(const char *mprefix, PGconn *conn, OM_uint32 maj_stat, OM_uint32 min_stat); -bool pg_GSS_have_cred_cache(gss_cred_id_t *cred_out); +gss_cred_id_t pg_GSS_get_cred_cache(void); int pg_GSS_load_servicename(PGconn *conn); = #endif diff --git a/src/interfaces/libpq/fe-secure-gssapi.c b/src/interfaces/libp= q/fe-secure-gssapi.c index 5ae10af5678..c43ab0294df 100644 --- a/src/interfaces/libpq/fe-secure-gssapi.c +++ b/src/interfaces/libpq/fe-secure-gssapi.c @@ -640,9 +640,9 @@ pqsecure_open_gss(PGconn *conn) = if (conn->gssdelegation && conn->gssdelegation[0] =3D=3D '1') { - /* Acquire credentials if possible */ + /* Attempt to acquire credentials, if we didn't already */ if (conn->gcred =3D=3D GSS_C_NO_CREDENTIAL) - (void) pg_GSS_have_cred_cache(&conn->gcred); + conn->gcred =3D pg_GSS_get_cred_cache(); = /* * We have credentials and gssdelegation is enabled, so request ------- =_aaaaaaaaaa0--