From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marko Tiikkaja <marko@joh.to>
cc: Andrei Gorita <andreigorita@gmail.com>,
        Pg Bugs <pgsql-bugs@postgresql.org>
Subject: Re: [BUGS] BUG #14870: wrong query results when using WITH with
 UPDATE
In-reply-to: <7584.1519069396@sss.pgh.pa.us>
References: <20171024155358.1471.82377@wrigleys.postgresql.org>
 <CAL9smLBOO8w9j2Y0zrRcdt-Kw2hiC8Ntdwro1FDq=j+z8Q9LqA@mail.gmail.com>
 <CAL9smLAa=LZTaN6Xm_cqY8mXCiQNB9FXLXr6thgtBi5Fo8WtEQ@mail.gmail.com>
 <7584.1519069396@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 19 Feb 2018 14:43:16 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2124.1519074339.1@sss.pgh.pa.us>
Date: Mon, 19 Feb 2018 16:05:39 -0500
Message-ID: <2125.1519074339@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> The answer turns out to be that if EPQ is fired, then we instantiate a new
> copy of the whole outer plan tree (though apparently not the InitPlan),
> resulting in an additional ExecInitCteScan call that allocates an
> additional read pointer on the same tuplestore, and it's that one being
> the active one that causes the observed misbehavior.

Oh, on closer inspection I had that backwards: the EPQ plan tree would
normally contain only the child node(s) of the ModifyTable node, but
EvalPlanQualStart also duplicates all InitPlan or SubPlan node trees,
because it can't tell which of them might get used within the EPQ subtree.
So we get one extra ExecInitCteScan call, even though no actual access
to the tuplestore could happen.

So we can now characterize the problem case as "CTE is read within an
InitPlan or SubPlan, and the query as a whole encounters an EPQ recheck".

			regards, tom lane