Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-bugs-owner+M39265=pgsql+2Dbugs=arkaria.postgresql.org@postgresql.org>)
 id 1XARYl-0007Gj-FD
 for pgsql-bugs@arkaria.postgresql.org; Thu, 24 Jul 2014 22:32:23 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-bugs-owner+M39265=pgsql+2Dbugs=arkaria.postgresql.org@postgresql.org>)
 id 1XARYk-0000qP-A2
 for pgsql-bugs@arkaria.postgresql.org; Thu, 24 Jul 2014 22:32:22 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
 by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <tgl@sss.pgh.pa.us>) id 1XARYi-0000qC-BV
 for pgsql-bugs@postgresql.org; Thu, 24 Jul 2014 22:32:20 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
 by magus.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <tgl@sss.pgh.pa.us>) id 1XARYe-0004VA-Od
 for pgsql-bugs@postgresql.org; Thu, 24 Jul 2014 22:32:19 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
 by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id s6OMW9pB021267;
 Thu, 24 Jul 2014 18:32:09 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@2ndquadrant.com>
cc: s.zuban@gmail.com, pgsql-bugs@postgresql.org,
 Heikki Linnakangas <hlinnakangas@vmware.com>
Subject: Re: BUG #11032: Prepared transactions do not update
 pg_last_xact_replay_timestamp() anymore
In-reply-to: <20140724215743.GG16857@alap3.anarazel.de>
References: <20140724191127.32089.82261@wrigleys.postgresql.org>
 <20429.1406238373@sss.pgh.pa.us> <20140724215743.GG16857@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@2ndquadrant.com>
 message dated "Thu, 24 Jul 2014 23:57:43 +0200"
Date: Thu, 24 Jul 2014 18:32:09 -0400
Message-ID: <21266.1406241129@sss.pgh.pa.us>
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-bugs>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-bugs.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@postgresql.org>
List-Post: <mailto:pgsql-bugs@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-bugs>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
X-Mailing-List: pgsql-bugs
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-07-24 17:46:13 -0400, Tom Lane wrote:
>> It looks to me like this never worked: the code around recoveryStopsHere
>> has never paid any attention to COMMIT_PREPARED (or ABORT_PREPARED).

> I wonder if this is possibly influenced by
> bb38fb0d43c8d7ff54072bfd8bd63154e536b384. IIRC before it committing a
> prepared xact caused a plain commit record for the xid doing the COMMIT
> PREPARED.

Hm, I see nothing in that commit that looks like it would've changed
what gets written to WAL (and if it did, we have a serious minor version
compatibility issue).  OTOH, if it did, that would explain the
complaint of a behavioral change since the last minor releases.

			regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs