From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Euler Taveira" <euler@eulerto.com>
cc: "Kong Man" <kong_mansatiansin@hotmail.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: pg_restore 14 skips ACL COLUMN when --schema is used
In-reply-to: <87065.1691588360@sss.pgh.pa.us>
References: 
 <DM4PR11MB73976902DBBA10B1D652F9498B06A@DM4PR11MB7397.namprd11.prod.outlook.com>
 <2427882.1690590240@sss.pgh.pa.us>
 <DM4PR11MB7397E0F1BFD8A839199B59838B05A@DM4PR11MB7397.namprd11.prod.outlook.com>
 <DM4PR11MB73970D090F35B7E1C2EEEB108B05A@DM4PR11MB7397.namprd11.prod.outlook.com>
 <90659bbc-e0cb-407d-b42b-5931346735ad@app.fastmail.com>
 <3317367.1691006807@sss.pgh.pa.us>
 <82fd2945-f56f-4e78-b0b5-222848ba8241@app.fastmail.com>
 <ece8667d-9824-4740-a150-617c9b3d9284@app.fastmail.com>
 <87065.1691588360@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 09 Aug 2023 09:39:20 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2132592.1696267783.1@sss.pgh.pa.us>
Date: Mon, 02 Oct 2023 13:29:43 -0400
Message-ID: <2132593.1696267783@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2132593.1696267783%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Hmm, changing it like that seems likely to have a lot of unexpected
> side-effects.  What I had in mind was to change the 

>             if (te->nDeps != 1 ||
>                 TocIDRequired(AH, te->dependencies[0]) == 0)
>                 return 0;

> bit so that it would loop through the TE's dependencies to see
> if any one of them is a required non-ACL TE.  We have to relax
> the "te->nDeps != 1" restriction, but we still want to check
> that there is a parent object that is being restored.

I improved the patch along those lines and pushed it.

			regards, tom lane