Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gUzcX-0006w1-3m for pgsql-bugs@arkaria.postgresql.org; Thu, 06 Dec 2018 19:47:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gUzcU-000733-R9 for pgsql-bugs@arkaria.postgresql.org; Thu, 06 Dec 2018 19:47:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gUzcU-00072w-Bq for pgsql-bugs@lists.postgresql.org; Thu, 06 Dec 2018 19:47:34 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gUzc8-0002wt-Jp for pgsql-bugs@lists.postgresql.org; Thu, 06 Dec 2018 19:47:32 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wB6JlAVK021377; Thu, 6 Dec 2018 14:47:10 -0500 From: Tom Lane To: Alvaro Herrera cc: ertugrul9090@gmail.com, Peter Eisentraut , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15511: Drop table error "invalid argument" In-reply-to: <20181206192422.nlxxj37hoi4p4b6o@alvherre.pgsql> References: <20181206192422.nlxxj37hoi4p4b6o@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Thu, 06 Dec 2018 16:24:22 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <21375.1544125630.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Thu, 06 Dec 2018 14:47:10 -0500 Message-ID: <21376.1544125630@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > On 2018-Nov-17, Tom Lane wrote: >> I poked at that to the extent of testing every string in 11.1's tr.po >> against our implementation of snprintf, and what I find is this: >> msgid "column %s of %s" >> msgstr "%2$s'nin %1$ sütunu" > I fixed this string in tr.po. At least it'll be correct in 11.2. Thanks! I'm also just about to push code changes for the easy parts of what I recommended earlier (have psprintf report the bogus format string, and make snprintf.c throw EINVAL for more error cases). Is anybody interested in the idea of making our own validator for the .po files? I might be willing to code it up, if I knew what its API ought to be, but I don't know the workflow in that area. regards, tom lane