From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Amit Langote <amitlangote09@gmail.com>, sbernikov@gmail.com,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17055: Logical replication worker crashes when applying
 update of row that dose not exist in target partiti
In-reply-to: <YMQOd4RvCq1ui19U@paquier.xyz>
References: <1828113.1623370641@sss.pgh.pa.us>
 <CA+HiwqG05LNWKv=fJDtF93LFmA99KCSZtnAJUAsjBOLFOPy-fA@mail.gmail.com>
 <YMMCFPuQwO6sEcJ+@paquier.xyz>
 <CA+HiwqF0xi2KmPYKPPCtcgQ2vnjQrfm5cdY50VRC+S_s1M4KvQ@mail.gmail.com>
 <1881335.1623423667@sss.pgh.pa.us> <2058966.1623442520@sss.pgh.pa.us>
 <YMP+Gx2S8meYYHW4@paquier.xyz> <2136546.1623457890@sss.pgh.pa.us>
 <YMQEO1EYRQX1cWGQ@paquier.xyz> <2138662.1623460441@sss.pgh.pa.us>
 <YMQOd4RvCq1ui19U@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Sat, 12 Jun 2021 10:31:35 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2139834.1623461825.1@sss.pgh.pa.us>
Date: Fri, 11 Jun 2021 21:37:05 -0400
Message-ID: <2139835.1623461825@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2139835.1623461825%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Still, the current style is not a pattern I think we should spread
> around, as a lot of copy-paste gets done in new tests added and one
> would easily mix up queries with pattern checks.  The practice I'd
> like to encourage is something like the attached, to make clear that
> there is no risk to fetch incorrect logs.

If you prefer.  However, I'd note that this patch as it stands
sort of breaks the argument I just made, as now you are interrogating
the postmaster's state after sending SIGHUP and before doing anything
that will wait for that to take effect.  I think you should move the
location-capture commands down by at least one safe_psql call.

			regards, tom lane