Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptKmX-00034Z-Sz for pgsql-bugs@arkaria.postgresql.org; Mon, 01 May 2023 04:04:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ptKmW-0008BQ-MO for pgsql-bugs@arkaria.postgresql.org; Mon, 01 May 2023 04:04:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptKmW-0008BH-Dw for pgsql-bugs@lists.postgresql.org; Mon, 01 May 2023 04:04:56 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ptKmT-0065k1-JU for pgsql-bugs@lists.postgresql.org; Mon, 01 May 2023 04:04:55 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 34144lvP2155321; Mon, 1 May 2023 00:04:47 -0400 From: Tom Lane To: Alexander Lakhin cc: Peter Geoghegan , pgsql-bugs@lists.postgresql.org, Richard Guo , Andres Freund Subject: Re: BUG #17798: Incorrect memory access occurs when using BEFORE ROW UPDATE trigger In-reply-to: <88b5750f-a5da-798b-e5a1-af2c3ecb9b60@gmail.com> References: <17798-0907404928dcf0dd@postgresql.org> <87fe6c28-80b2-f709-a8db-d105e5240e39@gmail.com> <1849610.1682807087@sss.pgh.pa.us> <88b5750f-a5da-798b-e5a1-af2c3ecb9b60@gmail.com> Comments: In-reply-to Alexander Lakhin message dated "Mon, 01 May 2023 07:00:00 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2155319.1682913887.1@sss.pgh.pa.us> Date: Mon, 01 May 2023 00:04:47 -0400 Message-ID: <2155320.1682913887@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alexander Lakhin writes: > So I'm going to start it over and find a repro that will show something > interesting without Valgrind (and let estimate the probability of a > problem in the field). I think a probability estimate is not all that exciting: "it's low but not zero" is sufficient information to act on. What I am curious about is how come 86dc90056's changes triggered a visible problem. Understanding that might give us a better feel for what is the real structural issue here --- which I'm worried about because I have little confidence that there aren't similar bugs lurking in other code paths. regards, tom lane