Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j7Ql3-0005Xc-9W for pgsql-bugs@arkaria.postgresql.org; Thu, 27 Feb 2020 21:31:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j7Ql1-0000Zw-3K for pgsql-bugs@arkaria.postgresql.org; Thu, 27 Feb 2020 21:31:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j7Ql0-0000Zp-O4 for pgsql-bugs@lists.postgresql.org; Thu, 27 Feb 2020 21:31:46 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j7Qkx-0005Fj-FV; Thu, 27 Feb 2020 21:31:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 01RLVYaU021598; Thu, 27 Feb 2020 16:31:34 -0500 From: Tom Lane To: Philip Semanchuk cc: Dave Page , Simon Riggs , Sergei Kornilov , "pgsql-bugs@lists.postgresql.org" Subject: Re: BUG #16279: Permissions doc incorrect for pg_buffercache In-reply-to: References: <16279-fcaac33c68aab0ab@postgresql.org> <21009351582737086@iva6-22e79380f52c.qloud-c.yandex.net> Comments: In-reply-to Philip Semanchuk message dated "Thu, 27 Feb 2020 16:13:17 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <21596.1582839094.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 27 Feb 2020 16:31:34 -0500 Message-ID: <21597.1582839094@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Philip Semanchuk writes: > On Feb 26, 2020, at 12:11 PM, Sergei Kornilov wrote: >> You are right, in contrib/pg_buffercache/pg_buffercache--1.2--1.3.sql w= e have >> GRANT EXECUTE ON FUNCTION pg_buffercache_pages() TO pg_monitor; >> GRANT SELECT ON pg_buffercache TO pg_monitor; >> Not pg_read_all_stats. I'm not sure: we need change the extension or fi= x the documentation? I think pg_read_all_stats would be more appropriate, = but we need bump the extension version. > Thanks for exploring and confirming! I agree that pg_read_all_stats woul= d be more appropriate. = Looking at the original discussion, it seems clear that the choice of pg_monitor was intentional; see in particular https://www.postgresql.org/message-id/CA%2BOCxowV7eL-DS1Hr-h5N7Tr8Gvn5VGW%= 2B%2BYJ2yo6wMN9H3n9Gg%40mail.gmail.com So I think the code is correct and the documentation is a typo. That's a much easier answer to back-patch, as well. regards, tom lane