From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ilya Anfimov <ilan@tzirechnoy.com>
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17646: create rule named "_RETURN" will cause pg core
In-reply-to: <20221017143338.GA3864491@azor.tzirechnoy.ru>
References: <17646-70c93cfa40365776@postgresql.org>
 <2164336.1666016275@sss.pgh.pa.us>
 <20221017143338.GA3864491@azor.tzirechnoy.ru>
Comments: In-reply-to Ilya Anfimov <ilan@tzirechnoy.com>
	message dated "Mon, 17 Oct 2022 17:33:38 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2173459.1666017695.1@sss.pgh.pa.us>
Date: Mon, 17 Oct 2022 10:41:35 -0400
Message-ID: <2173460.1666017695@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2173460.1666017695%40sss.pgh.pa.us>
Precedence: bulk

Ilya Anfimov <ilan@tzirechnoy.com> writes:
> On Mon, Oct 17, 2022 at 10:17:55AM -0400, Tom Lane wrote:
>> (Although the core dump is also not great --- something should've noticed
>> the bogosity of the plan earlier than this.)

>  Id doesn't look much of a plan bogosity,
> but rather implicit deletion of the "_RETURN" on select rule.

Right, but then since there's no applicable rule, we end up generating
a plan that tries to do a seqscan directly on the view relation,
which of course lacks storage.  Something should notice that a little
sooner than segfaulting because of rel->rd_tableam being NULL --- it's
not like we don't have hundreds of other sanity checks for not-really-
supposed-to-happen catalog corruption.

In versions before v12, I get something like

regression=# select * from v1;
ERROR:  could not open file "base/16384/49209": No such file or directory

which is a shade less bad, but still not great.

			regards, tom lane