From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mats Kindahl <mats@timescale.com>
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17876: Function width_bucket() for float8 input returns
 value out of range
In-reply-to: 
 <CA+14427tOx9GXw2Va_W0HF7Wp7kiu31BNju_=3SnCuaXOAdJzQ@mail.gmail.com>
References: <17876-61f280d1601f978d@postgresql.org>
 <CA+14427KvPsskajKSriGACyrudcOyh5ohmt=0WPuNjoMTSQM6A@mail.gmail.com>
 <3807420.1680093217@sss.pgh.pa.us>
 <CA+14424DZUcLpWnoRURmT1m6Uet1_R39sV=8XhtFRiigVtYqDg@mail.gmail.com>
 <186575.1680190503@sss.pgh.pa.us>
 <CA+14425g=sw2g+6KYCfz2x1YwYz0X2MwWeUu0U5Ba8BHkSi2jw@mail.gmail.com>
 <391415.1680268470@sss.pgh.pa.us>
 <CA+14427tOx9GXw2Va_W0HF7Wp7kiu31BNju_=3SnCuaXOAdJzQ@mail.gmail.com>
Comments: In-reply-to Mats Kindahl <mats@timescale.com>
	message dated "Wed, 05 Apr 2023 09:58:27 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2173636.1680730866.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Wed, 05 Apr 2023 17:41:06 -0400
Message-ID: <2173637.1680730866@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2173637.1680730866%40sss.pgh.pa.us>
Precedence: bulk

Mats Kindahl <mats@timescale.com> writes:
> On Fri, Mar 31, 2023 at 3:14 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> While I'm not bothered too much if rounding affects which internal
>> bucket a value lands in, it's a bit more annoying if that causes
>> it to be reported as being in the end bucket, when we know positively
>> that the value is less than bound2.  Is it worth expending more
>> cycles to prevent this?

> I think it could be. I agree that it does not make sense to select the end
> bucket when the value is in range, even if just.

Yeah.  I did that already at a2a0c7c29, sorry for not circling back
to this thread.

			regards, tom lane