Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiXE7-0006w9-HM for pgsql-bugs@arkaria.postgresql.org; Tue, 09 Jun 2020 05:55:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jiXE6-0001jE-DR for pgsql-bugs@arkaria.postgresql.org; Tue, 09 Jun 2020 05:55:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiXE6-0001j5-6a for pgsql-bugs@lists.postgresql.org; Tue, 09 Jun 2020 05:55:10 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiXE3-000220-LM for pgsql-bugs@lists.postgresql.org; Tue, 09 Jun 2020 05:55:09 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0595t67a2192707; Tue, 9 Jun 2020 01:55:06 -0400 From: Tom Lane To: Michael Paquier cc: Daniel Gustafsson , r.zharkov@postgrespro.ru, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16484: pg_regress fails with --outputdir parameter In-reply-to: <20200609053356.GC38342@paquier.xyz> References: <16484-4d89e9cc11241996@postgresql.org> <153B2C23-E972-4D2B-BBD3-EA77AEB79329@yesql.se> <20200609053356.GC38342@paquier.xyz> Comments: In-reply-to Michael Paquier message dated "Tue, 09 Jun 2020 14:33:56 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2192705.1591682106.1@sss.pgh.pa.us> Date: Tue, 09 Jun 2020 01:55:06 -0400 Message-ID: <2192706.1591682106@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier writes: > And this leads me to the attached. That will create the output directory even if indir doesn't exist, which seems likely to lead to bogus directories hanging around in places where we don't need them --- plus it seems rather ugly to drop this into the middle of the sequence concerned with indir. So shouldn't the new code be after the exit for indir not existing? regards, tom lane