From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
cc: Jeremy Evans <code@jeremyevans.net>,
 Michael Paquier <michael@paquier.xyz>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
In-reply-to: <87o9d8rv08.fsf@news-spur.riddles.org.uk>
References: <153626613985.23143.4743626885618266803@wrigleys.postgresql.org>
 <20180906215836.GP2726@paquier.xyz>
 <20180906222843.GF17425@jeremyevans.local>
 <20180907165103.GH17425@jeremyevans.local>
 <20180907175518.GI17425@jeremyevans.local>
 <20180907181522.GB32058@paquier.xyz> <20016.1536351535@sss.pgh.pa.us>
 <20180907204403.GC32058@paquier.xyz> <16558.1536407783@sss.pgh.pa.us>
 <18398.1536410055@sss.pgh.pa.us> <87o9d8rv08.fsf@news-spur.riddles.org.uk>
Comments: In-reply-to Andrew Gierth <andrew@tao11.riddles.org.uk>
	message dated "Sat, 08 Sep 2018 14:22:22 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22024.1536521375.1@sss.pgh.pa.us>
Date: Sun, 09 Sep 2018 15:29:35 -0400
Message-ID: <22025.1536521375@sss.pgh.pa.us>
Precedence: bulk

Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> Is this potentially also a problem for libpqwalreceiver, which also
> loads libpq?

As far as I can see, only libpq and the ECPG libraries build their
own copies of any src/port or src/common files, and all of them already
have version scripts.  If libpqwalreceiver tried to incorporate any
such files and compile them under FRONTEND rules, it'd need a version
script as well.  But I think that code is probably content to operate
under backend rules, so it'll just use the functions from the core
backend and be happy.  Hence, no clear need for a version script there.

I think the patches I committed today are sufficient to close this bug,
unless further testing reveals that the problem occurs on additional
platforms.  The buildfarm results so far don't suggest that.

			regards, tom lane