From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
cc: David Rowley <dgrowleyml@gmail.com>, zuming.jiang@inf.ethz.ch,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18277: Unexpected error: "WindowFunc not found in subplan
 target lists" triggered by JOIN and Window Func
In-reply-to: 
 <CAMbWs4_g0-toa_BH3M-ocFoJLcLKuxL=wdaBho60+r7vVy+c=w@mail.gmail.com>
References: <18277-089ead83b329a2fd@postgresql.org>
 <2063207.1704754792@sss.pgh.pa.us>
 <CAMbWs4_g0-toa_BH3M-ocFoJLcLKuxL=wdaBho60+r7vVy+c=w@mail.gmail.com>
Comments: In-reply-to Richard Guo <guofenglinux@gmail.com>
	message dated "Tue, 09 Jan 2024 15:35:08 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2228853.1704836071.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Tue, 09 Jan 2024 16:34:31 -0500
Message-ID: <2228854.1704836071@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2228854.1704836071%40sss.pgh.pa.us>
Precedence: bulk

Richard Guo <guofenglinux@gmail.com> writes:
> On Tue, Jan 9, 2024 at 7:00 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> PG Bug reporting form <noreply@postgresql.org> writes:
>>> My fuzzer finds a bug in Postgres 17devel, which triggers an unexpected
>>> error "ERROR: WindowFunc not found in subplan target lists".

> I think this is caused by that query_tree_mutator fails to mutate
> runCondition for WindowClause.

Ugh!  That seems quite horrid.  David, was there a reason to not do
that, or was it just an oversight?

> I think we should also consider WindowClause->runCondition in
> query_tree_walker, expression_tree_mutator and expression_tree_walker.

Offhand, +1.  If it has the form of an ordinary expression tree
then it really needs to be processed in all these places.

			regards, tom lane