Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1m1tYA-0007Kl-EQ
	for pgsql-bugs@arkaria.postgresql.org; Fri, 09 Jul 2021 16:40:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1m1tY9-0007tO-Bk
	for pgsql-bugs@arkaria.postgresql.org; Fri, 09 Jul 2021 16:40:25 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1m1tY9-0007tE-5C
	for pgsql-bugs@lists.postgresql.org; Fri, 09 Jul 2021 16:40:25 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1m1tY5-0002EV-54
	for pgsql-bugs@lists.postgresql.org; Fri, 09 Jul 2021 16:40:24 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 169GeGwW2229968;
	Fri, 9 Jul 2021 12:40:16 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Daniel Gustafsson <daniel@yesql.se>, Adrian Ho <ml+postgresql@03s.net>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x
In-reply-to: <YOezfzxbrMNMwoRg@paquier.xyz>
References: <17083-a19190d9591946a7@postgresql.org>
 <1666182.1625579201@sss.pgh.pa.us>
 <cc729116-2a2d-9edd-a32d-4066b92e4a75@03s.net>
 <1677203.1625582865@sss.pgh.pa.us>
 <e78eb1f9-57b1-dae9-39c8-5dd72268be89@03s.net>
 <1860066.1625677051@sss.pgh.pa.us>
 <68D22062-EC78-47C5-BC46-EF2F77193E19@yesql.se>
 <YOaxpoHOiO7Q41F2@paquier.xyz> <2040197.1625774127@sss.pgh.pa.us>
 <C184CEB8-F2D5-4CD7-BDA1-D9F6AD43DD14@yesql.se>
 <YOezfzxbrMNMwoRg@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 09 Jul 2021 11:25:03 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2229966.1625848816.1@sss.pgh.pa.us>
Date: Fri, 09 Jul 2021 12:40:16 -0400
Message-ID: <2229967.1625848816@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/2229967.1625848816%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Jul 08, 2021 at 10:02:30PM +0200, Daniel Gustafsson wrote:
>> On 8 Jul 2021, at 21:55, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> That being the case, I think we might be okay just going with the
>>> solution in Adrian's last patch, ie use libldap_r if it's there
>>> and otherwise assume that libldap is thread-safe.

>> Absolutely, in light of that I agree that's the best option.

> +1.

Done that way.

			regards, tom lane