From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: Noah Misch <noah@leadboat.com>, neverov.max@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
In-reply-to: <20210426165435.GT7629@momjian.us>
References: <16939-cceeb03fb72736ee@postgresql.org>
 <20210323160336.GE579@momjian.us> <20210425115726.GA2353095@rfd.leadboat.com>
 <20210426163116.GR7629@momjian.us> <2266336.1619455534@sss.pgh.pa.us>
 <20210426165435.GT7629@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Mon, 26 Apr 2021 12:54:35 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2267468.1619456564.1@sss.pgh.pa.us>
Date: Mon, 26 Apr 2021 13:02:44 -0400
Message-ID: <2267469.1619456564@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2267469.1619456564%40sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> On Mon, Apr 26, 2021 at 12:45:34PM -0400, Tom Lane wrote:
>> I agree with Noah's opinion that we should stick to the historical
>> behavior in the interval I/O functions.  There is not enough solidity
>> in the "this is grammatically wrong" argument to justify taking any
>> risk of application breakage, and it seems like there is some risk of
>> that there.

> Are you saying we should revert the patch and leave the plurals
> inconsistent in different places?

As far as the changes in datetime.c and interval.c are concerned,
yes.  I don't care too much about what you did in fe-print.c,
although TBH that case should be unreachable shouldn't it?
When would PQntuples() return -1?

(I shy gently away from the fact that that fe-print.c code is
relentlessly untranslatable.)

			regards, tom lane