From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Stephen Frost <sfrost@snowman.net>, Jelte Fennema <postgres@jeltef.nl>,
        Michael Paquier <michael@paquier.xyz>, duspensky@ya.ru,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16160: Minor memory leak in case of starting postgres server
 with SSL encryption
In-reply-to: <20210320000732.zaq227u5spnhwytr@alap3.anarazel.de>
References: <16160-18367e56e9a28264@postgresql.org>
 <20191213063915.GE1942@paquier.xyz> <20191214092456.GB70616@paquier.xyz>
 <CAGECzQTucR20CLwb6mw_JLdVST8GqYNqYr1OmAnNS2Byg8r+dg@mail.gmail.com>
 <20210316184455.GB20766@tamriel.snowman.net>
 <20210320000732.zaq227u5spnhwytr@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 19 Mar 2021 17:07:32 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <227068.1616259027.1@sss.pgh.pa.us>
Date: Sat, 20 Mar 2021 12:50:27 -0400
Message-ID: <227069.1616259027@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/227069.1616259027%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2021-03-16 14:44:55 -0400, Stephen Frost wrote:
>> OOMs errors should be gracefully handled and PG should continue to
>> function.  Was that not the case..?

> Depends on what you mean with graceful. Unless you restart the database
> you'll eventually not be able to do anything anymore, since even the
> smallest memory allocation will fail?

Yeah, a leak in the postmaster is not gonna end well.

I went ahead and back-patched e0e569e1d.  While looking at that,
I noticed that the load_dh_file subroutine was also a few DH_frees
shy of a load, so I fixed that too.

			regards, tom lane