From: Tom Lane <tgl@sss.pgh.pa.us>
To: BharatDB <bharatdbpg@gmail.com>
cc: torsten.rupp@gmx.net, pgsql-bugs@lists.postgresql.org, michael@paquier.xyz,
        VASUKI M <vasukim1992002@gmail.com>
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
In-reply-to: <CAAh00ETwx8_AEM0wgoi-v875uC-FLuGGOMTaP9fCNdVw4Zq=Vg@mail.gmail.com>
References: <19095-6d8256d0c37d4be2@postgresql.org> <CAAh00ETwx8_AEM0wgoi-v875uC-FLuGGOMTaP9fCNdVw4Zq=Vg@mail.gmail.com>
Comments: In-reply-to BharatDB <bharatdbpg@gmail.com>
	message dated "Wed, 12 Nov 2025 11:23:10 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2305434.1762929527.1@sss.pgh.pa.us>
Date: Wed, 12 Nov 2025 01:38:47 -0500
Message-ID: <2305435.1762929527@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2305435.1762929527%40sss.pgh.pa.us>
Precedence: bulk

BharatDB <bharatdbpg@gmail.com> writes:
>> [1]Changing the grep pattern to match the exact symbol ('grep -x exit')
>> prevents such false positives.

We might as well remove the test entirely as do that; it would
fail to detect "_exit" for example.

Additionally, I don't have a lot of faith in "grep -x" being
universally portable.  POSIX 2018 does specify that switch, but
it mentions that it is "historically available only with fgrep".

Personally I'm okay with whitelisting pthread_exit() as
Torsten suggested.

BTW, it looks like libpq's meson.build is missing this check.

			regards, tom lane