From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: usamoi@outlook.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18637: CREATE INDEX won't look up operator classes in
 search_path if PARTITION BY is specified
In-reply-to: 
 <CAApHDvrmBSTA8-Sv=HEQvrPO8QDPLB7y0d0gJweBQe2c8PMGYw@mail.gmail.com>
References: <18637-f51e314546e3ba2a@postgresql.org>
 <CAApHDvrmBSTA8-Sv=HEQvrPO8QDPLB7y0d0gJweBQe2c8PMGYw@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Thu, 03 Oct 2024 16:11:40 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <231374.1727925543.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Wed, 02 Oct 2024 23:19:03 -0400
Message-ID: <231375.1727925543@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/231375.1727925543%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> There's an item in the release notes [1] which should be expended to
> mention this as an incompatibility, namely:

> "Change functions to use a safe search_path during maintenance
> operations (Jeff Davis) §

I have not dug into the code, but I think this may actually be a
bug; not because of the change of search path, but because it looks
like the opclass is probably being looked up more than once during
the command, with different search paths.  That has security
implications, and not good ones.  We should fix this so that the
opclass is looked up exactly once, and passed down to the partitions
by OID not name.

			regards, tom lane