Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1loZod-0004SQ-KI
	for pgsql-bugs@arkaria.postgresql.org; Wed, 02 Jun 2021 22:58:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1loZoc-00026I-Fi
	for pgsql-bugs@arkaria.postgresql.org; Wed, 02 Jun 2021 22:58:22 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1loZoc-00026A-8p
	for pgsql-bugs@lists.postgresql.org; Wed, 02 Jun 2021 22:58:22 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1loZoZ-0004e9-Vj
	for pgsql-bugs@lists.postgresql.org; Wed, 02 Jun 2021 22:58:21 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 152MwHHt232376;
	Wed, 2 Jun 2021 18:58:17 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Sosinski <robert.sosinski@reactive.io>
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17045: 14 Beta Tighten up allowed names for custom GUC
 parameters breaks PostgREST
In-reply-to: 
 <CAFkjL2WRM9wnR6vBgypnGzqW+5aTqvYiM1J12Nwg0-KZadatSQ@mail.gmail.com>
References: <17045-6a4a9f0d1513f72b@postgresql.org>
 <165910.1622665167@sss.pgh.pa.us>
 <CAFkjL2WRM9wnR6vBgypnGzqW+5aTqvYiM1J12Nwg0-KZadatSQ@mail.gmail.com>
Comments: In-reply-to Robert Sosinski <robert.sosinski@reactive.io>
	message dated "Wed, 02 Jun 2021 17:20:03 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <232374.1622674697.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 02 Jun 2021 18:58:17 -0400
Message-ID: <232375.1622674697@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/232375.1622674697%40sss.pgh.pa.us>
Precedence: bulk

Robert Sosinski <robert.sosinski@reactive.io> writes:
> I would revise my statement to say this change to PostgreSQL 14 would
> significantly break existing PostgREST applications, to the point that t=
hey
> would be unable to upgrade to 14.

Fair enough.  I also dug around a bit and noted that the core grammar
explicitly allows SET/SHOW variable names to have any number of
components:

var_name:   ColId                                { $$ =3D $1; }
            | var_name '.' ColId
                { $$ =3D psprintf("%s.%s", $1, $3); }
        ;

That dates clear back to commit 3dc37cd8d of 2004-05-26.  While it's
fair to wonder how intentional it was, given that the commit log
message only mentions "qualified name in the form <ID>.<ID>",
nonetheless people have been able to write this --- without any tricks
like double-quotes --- for a mighty long time.  So I now agree that
we shouldn't forbid it.  Done at

https://git.postgresql.org/gitweb/?p=3Dpostgresql.git;a=3Dcommitdiff;h=3D2=
955c2be79b35fa369c83fa3b5f44661cb88afa9

			regards, tom lane