From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: martin@schlossarek.me, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18057: unaccent removes intentional spaces
In-reply-to: <ZN8NUpx2f9pB+F/g@paquier.xyz>
References: <18057-62712cad01bd202c@postgresql.org>
 <ZNwRq4nV7CBXAoJN@paquier.xyz> <ZN8NUpx2f9pB+F/g@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 18 Aug 2023 15:18:58 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2334731.1692462604.1@sss.pgh.pa.us>
Date: Sat, 19 Aug 2023 12:30:04 -0400
Message-ID: <2334732.1692462604@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2334732.1692462604%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> I was looking at the code, and my first impression was right.  All
> leading and trailing whitespaces between the two characters listed in
> the rule file are discarded.  The thing is that we clearly document
> the parsing rules for the sake of any custom files one can feed to the
> extension:
> https://www.postgresql.org/docs/devel/unaccent.html

> I am not sure what we can do here.  Doing nothing is certainly an
> option, but I am wondering if we could put in place an extra rule
> where whitespaces can be part of the translated character if it uses
> double quotes, for example.  Thoughts?

Yeah, we could extend the parsing rules that way.  It would break
any rules files that currently use double quote as a plain character,
but it seems unlikely that there are any.  In any case, as long as
this wasn't back-patched I think such a change would be acceptable.

			regards, tom lane