Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLuFw-0004yX-P4 for pgsql-bugs@arkaria.postgresql.org; Thu, 02 Sep 2021 21:28:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mLuFv-0004R8-Pl for pgsql-bugs@arkaria.postgresql.org; Thu, 02 Sep 2021 21:28:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLuFv-0004Qv-JD for pgsql-bugs@lists.postgresql.org; Thu, 02 Sep 2021 21:28:19 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLuFt-0001HM-I8 for pgsql-bugs@lists.postgresql.org; Thu, 02 Sep 2021 21:28:19 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 182LS4Qw2359862; Thu, 2 Sep 2021 17:28:04 -0400 From: Tom Lane To: ma100@hotmail.com cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #17172: NaN compare error in hash agg In-reply-to: <2077133.1630510836@sss.pgh.pa.us> References: <17172-7505bea9e04e230f@postgresql.org> <2077133.1630510836@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Wed, 01 Sep 2021 11:40:36 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2359860.1630618084.1@sss.pgh.pa.us> Date: Thu, 02 Sep 2021 17:28:04 -0400 Message-ID: <2359861.1630618084@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I wrote: > This has been broken for a very long time. Do we dare back-patch > the fix? Given the lack of complaints, maybe fixing it in HEAD/v14 > is enough. OTOH, it's not likely that many people have hash indexes > containing minus NaNs, so maybe it's okay to back-patch. After further thought I concluded that there's little reason not to back-patch. If someone has -NaN in a hash index, they'd need to re-index if they ever want to find that entry again ... but it was already true that many queries would not find that entry. Hence, pushed to all branches. regards, tom lane