Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kv0oB-0008N7-PU for pgsql-bugs@arkaria.postgresql.org; Thu, 31 Dec 2020 16:28:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kv0nc-0000m7-Fp for pgsql-bugs@arkaria.postgresql.org; Thu, 31 Dec 2020 16:27:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kv0nc-0000lz-9s for pgsql-bugs@lists.postgresql.org; Thu, 31 Dec 2020 16:27:40 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kv0nU-0004YV-QN for pgsql-bugs@lists.postgresql.org; Thu, 31 Dec 2020 16:27:39 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0BVGRR772457720; Thu, 31 Dec 2020 11:27:27 -0500 From: Tom Lane To: oleg9301 xz cc: pgsql-bugs@lists.postgresql.org, Fujii Masao , Peter Eisentraut Subject: Re: BUG #16799: postgresql log issue(last completed transaction was at log time) In-reply-to: References: <16799-af1b66268fe20d0d@postgresql.org> <2452476.1609428095@sss.pgh.pa.us> Comments: In-reply-to oleg9301 xz message dated "Thu, 31 Dec 2020 18:33:45 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <2457718.1609432047.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Thu, 31 Dec 2020 11:27:27 -0500 Message-ID: <2457719.1609432047@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk oleg9301 xz writes: > чт, 31 дек. 2020 г. в 18:21, Tom Lane : >> PG Bug reporting form writes: >>> After recovering postgresql from barman, in version 12.5 I don't have >>> next string >>> "last completed transaction was at log time %s" >>> In postgresql 11.9-1.pgdg100+1 everything fine. >> I don't see any reason to believe there's a bug here. That message >> would only appear if at least one transaction commit or abort record was >> replayed from WAL, and it's quite possible there wouldn't have been. > There is always transations to commit, I(barman) do pg_basebackup once a > day, and recieve wal with pg_receivewal(standby slot). And everything is > fine, i have all data on OLAP DB(restore 6 times in day) > (all WAL files playing correctly). Hmm. I poked a bit into the code, and I see what is different in v12: commit 7acf8a876 ("Make crash recovery ignore recovery target settings") caused all of recoveryStopsAfter() to be skipped when !ArchiveRecoveryRequested ... including the part that updates recoveryLastXTime. Fujii-san, Peter, was that actually intended? The commit message doesn't mention it. It's certainly arguable that this is cosmetic and we don't care enough to contort the code to keep the old behavior here. regards, tom lane