From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Janes <jeff.janes@gmail.com>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Query generates infinite loop
In-reply-to: 
 <CAMkU=1yp1S5cwj_e762D_tNHT5w=ZKDB3k6UCmSaTkbnddSwOA@mail.gmail.com>
References: <91B44E7B-68D5-448F-95C8-B4B3B0F5DEAF@duckdblabs.com>
 <CAFj8pRDzVzTfsnxs_T9T7k=HW_gWCryo==rVB-AX4R6pXo85xQ@mail.gmail.com>
 <2842828.1650474225@sss.pgh.pa.us> <3010353.1650490989@sss.pgh.pa.us>
 <CAMkU=1yp1S5cwj_e762D_tNHT5w=ZKDB3k6UCmSaTkbnddSwOA@mail.gmail.com>
Comments: In-reply-to Jeff Janes <jeff.janes@gmail.com>
	message dated "Wed, 04 May 2022 15:01:27 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2459339.1651692261.1@sss.pgh.pa.us>
Date: Wed, 04 May 2022 15:24:21 -0400
Message-ID: <2459340.1651692261@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2459340.1651692261%40sss.pgh.pa.us>
Precedence: bulk

Jeff Janes <jeff.janes@gmail.com> writes:
> The regression test you added for this change causes an infinite loop when
> run against an unpatched server with --install-check.  That is a bit
> unpleasant.  Is there something we can and should do about that?  I was
> expecting regression test failures of course but not an infinite loop
> leading towards disk exhaustion.

We very often add regression test cases that will cause unpleasant
failures on unpatched code.  I categorically reject the idea that
that's not a good thing, and question why you think that running
known-broken code against a regression suite is an important use case.

			regards, tom lane