From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: luy70@psu.edu, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18877: PostgreSQL triggers assertion failure
In-reply-to: <202504051500.v6ekizm5fcv4@alvherre.pgsql>
References: <202504051500.v6ekizm5fcv4@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Sat, 05 Apr 2025 17:00:44 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2461844.1743865979.1@sss.pgh.pa.us>
Date: Sat, 05 Apr 2025 11:12:59 -0400
Message-ID: <2461845.1743865979@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2461845.1743865979%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2025-Apr-05, Tom Lane wrote:
>> So what we should be doing is building a parse-analysis result
>> that deparses into something that looks like the input; probably,
>> a JsonArrayQueryConstructor node with an analyzed EXPR_SUBLINK
>> SubLink below it.  Then we can make this tlist-length check against
>> the analyzed SubLink, removing the problem of premature errors that
>> are not spelled the way we want.

> Sounds reasonable, I can try to find better coding for this, but it
> won't be soon.  I won't be sad if somebody else wants to do it, so if
> you feel like it, please be my guest.

Yeah, it's not high priority for me either.  Maybe someone else
will be interested in the project.

>> Anyway, that idea is far too invasive to be back-patchable,
>> and IMO it's too late to consider even getting it into v18.
>> So what I'm thinking is we should just apply the copyObject
>> hack for now, and resolve to reconsider this code later.

> Sounds reasonable.

OK, I'll get that done.

			regards, tom lane