Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.500.181\))
Subject: Re: Potential buffer overrun in spell.c's CheckAffix()
From: Andrey Borodin <x4mmm@yandex-team.ru>
In-Reply-To: <E8FF434D-BE94-4E37-B195-41CA1A33357D@yandex-team.ru>
Date: Thu, 30 Apr 2026 10:56:17 +0300
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <2480A4C7-E144-474F-B4DD-D9D798526E6E@yandex-team.ru>
References: <641711.1776792744@sss.pgh.pa.us>
 <F6506DC9-7E95-4FA3-A9E3-37392E92463D@yandex-team.ru>
 <959933.1776865480@sss.pgh.pa.us>
 <E8FF434D-BE94-4E37-B195-41CA1A33357D@yandex-team.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2480A4C7-E144-474F-B4DD-D9D798526E6E%40yandex-team.ru>
Precedence: bulk


> On 23 Apr 2026, at 12:58, Andrey Borodin <x4mmm@yandex-team.ru> wrote:
>=20
> Yes, 40Kb in NIImportOOAffixes() is a lot. But is it important in =
grand scheme of
> things? Minimum max_stack_depth is 100Kb, ought to be enough=E2=80=A6

IsAffixFlagInUse(), addCompoundAffixFlagValue() and =
getCompoundAffixFlagValue()
also allocate 8Kb on stack...
Would it make sense to add check_stack_depth() into =
addCompoundAffixFlagValue()?
Other prominent allocators (NIImportOOAffixes(),NIImportAffixes()) call =
it anyway.
At least we will know if disaster is around the corner.


Best regards, Andrey Borodin.=