From: Tom Lane <tgl@sss.pgh.pa.us>
To: vidushi2504@gmail.com
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18407: ALTER TABLE SET SCHEMA on foreign table with SERIAL
 column does not move sequence to new schema
In-reply-to: <18407-4fd07373d252c6a0@postgresql.org>
References: <18407-4fd07373d252c6a0@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Mon, 25 Mar 2024 14:50:53 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2497747.1711383445.1@sss.pgh.pa.us>
Date: Mon, 25 Mar 2024 12:17:25 -0400
Message-ID: <2497748.1711383445@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2497748.1711383445%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> I created a foreign table with a serial column and then moved the table to a
> different schema. The sequence bound to the table column wasn't moved to the
> new schema. I expected the sequence to be moved as well just like it works
> for regular tables.

Hmm ... that does seem fairly inconsistent.  It looks like the cause
is in AlterTableNamespaceInternal:

    /* Fix other dependent stuff */
    if (rel->rd_rel->relkind == RELKIND_RELATION ||
        rel->rd_rel->relkind == RELKIND_MATVIEW ||
        rel->rd_rel->relkind == RELKIND_PARTITIONED_TABLE)
    {
        AlterIndexNamespaces(classRel, rel, oldNspOid, nspOid, objsMoved);
        AlterSeqNamespaces(classRel, rel, oldNspOid, nspOid,
                           objsMoved, AccessExclusiveLock);
        AlterConstraintNamespaces(RelationGetRelid(rel), oldNspOid, nspOid,
                                  false, objsMoved);
    }

It's probably reasonable to have this relkind gating for 
AlterIndexNamespaces, although I'm not sure it saves much to
skip that, either.  But we can have sequences attached to
foreign tables, and I think maybe constraints as well.
Maybe it'd be best to just drop this relkind check altogether?

			regards, tom lane