From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andres Freund <andres@anarazel.de>, jungleboogie0@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared
 identifier 'FD_SETSIZE'
In-reply-to: <20190819044625.GA18166@paquier.xyz>
References: <15964-c1753bdfed722e04@postgresql.org>
 <24757.1566073861@sss.pgh.pa.us>
 <20190817210025.v4bblh4lhsxajmlj@alap3.anarazel.de>
 <6402.1566079145@sss.pgh.pa.us>
 <20190817224142.gq57z3cwt7c76dtk@alap3.anarazel.de>
 <20190819044625.GA18166@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 19 Aug 2019 13:46:25 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <25240.1566191643.1@sss.pgh.pa.us>
Date: Mon, 19 Aug 2019 01:14:03 -0400
Message-ID: <25241.1566191643@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Sat, Aug 17, 2019 at 03:41:42PM -0700, Andres Freund wrote:
>>> Indeed.  I've confirmed the bug report on a local OpenBSD 6.4 build
>>> (clang 6.0.0), and with "make -k" I can see that reindexdb.c fails
>>> likewise.  But this is unsurprising given that POSIX says that
>>> FD_SETSIZE is declared by sys/select.h.

>> Right.

> Okay, then the current code is broken in this sense.  It was
> surprising to not see the buildfarm complain about that though.

Yeah --- see 51c3e9fad.  We should have set up a modern-OpenBSD
buildfarm member back then, but failed to.  Let's do that this
time.

			regards, tom lane