Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYR37-00BL53-KT for pgsql-bugs@arkaria.postgresql.org; Mon, 29 Jul 2024 14:08:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sYR35-000Fz5-H8 for pgsql-bugs@arkaria.postgresql.org; Mon, 29 Jul 2024 14:08:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYR35-000Fyx-8d for pgsql-bugs@lists.postgresql.org; Mon, 29 Jul 2024 14:08:27 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYR2z-0024xv-7o for pgsql-bugs@lists.postgresql.org; Mon, 29 Jul 2024 14:08:26 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 46TE8JVx2580689; Mon, 29 Jul 2024 10:08:19 -0400 From: Tom Lane To: Peter Smith cc: David Rowley , exclusion@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18558: ALTER PUBLICATION fails with unhelpful error on attempt to use system column In-reply-to: References: <18558-411bc81b03592125@postgresql.org> <2455740.1722219823@sss.pgh.pa.us> <2460423.1722222076@sss.pgh.pa.us> Comments: In-reply-to Peter Smith message dated "Mon, 29 Jul 2024 18:10:56 +1000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2580687.1722262099.1@sss.pgh.pa.us> Date: Mon, 29 Jul 2024 10:08:19 -0400 Message-ID: <2580688.1722262099@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Smith writes: > TBH, I was unsure if this error bugfix patch qualified to have > backpatches or not. Although it is a "bug" it was not impacting > anybody because it is only substituting one error msg for another > nicer error msg. True, we don't really have to back-patch. I'm inclined to do so, but might think differently once we see how big the final patch is. regards, tom lane