From: Tom Lane <tgl@sss.pgh.pa.us>
To: "=?ISO-8859-1?B?WmhhbyBSdWk=?=" <875941708@qq.com>
cc: pgsql-hackers@lists.postgresql.org,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        masao.fujii@oss.nttdata.com, Nathan Bossart <nathandbossart@gmail.com>
Subject: Re: Fix primary crash continually with invalid checkpoint after
 promote
In-reply-to: <tencent_1D53DA1DFA2F5EF11B0D6B9DD24FF8BD4A08@qq.com>
References: <tencent_1D53DA1DFA2F5EF11B0D6B9DD24FF8BD4A08@qq.com>
Comments: In-reply-to "=?ISO-8859-1?B?WmhhbyBSdWk=?=" <875941708@qq.com>
	message dated "Tue, 26 Apr 2022 15:16:13 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <258771.1651002433.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 26 Apr 2022 15:47:13 -0400
Message-ID: <258772.1651002433@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/258772.1651002433%40sss.pgh.pa.us>
Precedence: bulk

"=3D?ISO-8859-1?B?WmhhbyBSdWk=3D?=3D" <875941708@qq.com> writes:
> Newly promoted primary may leave an invalid checkpoint.
> In function CreateRestartPoint, control file is updated and old wals are=
 removed. But in some situations, control file is not updated, old wals ar=
e still removed. Thus produces an invalid checkpoint with nonexistent wal.=
 Crucial log: "invalid primary checkpoint record", "could not locate a val=
id checkpoint record".

I believe this is the same issue being discussed here:

https://www.postgresql.org/message-id/flat/20220316.102444.219318148757661=
7583.horikyota.ntt%40gmail.com

but Horiguchi-san's proposed fix looks quite different from yours.

			regards, tom lane