Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJHBC-0003go-0c for pgsql-bugs@arkaria.postgresql.org; Tue, 31 Mar 2020 13:43:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jJHBA-0008HX-MU for pgsql-bugs@arkaria.postgresql.org; Tue, 31 Mar 2020 13:43:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJHBA-0008HQ-G1 for pgsql-bugs@lists.postgresql.org; Tue, 31 Mar 2020 13:43:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJHB7-0002hQ-ND for pgsql-bugs@lists.postgresql.org; Tue, 31 Mar 2020 13:43:44 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 02VDhawg002590; Tue, 31 Mar 2020 09:43:36 -0400 From: Tom Lane To: Michael Paquier cc: Alvaro Herrera , hghwng@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16330: psql accesses null pointer in connect.c:do_connect In-reply-to: <20200331072153.GB1549@paquier.xyz> References: <17009.1585582541@sss.pgh.pa.us> <20200330154851.GA15986@alvherre.pgsql> <20200331072153.GB1549@paquier.xyz> Comments: In-reply-to Michael Paquier message dated "Tue, 31 Mar 2020 16:21:53 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2588.1585662216.1@sss.pgh.pa.us> Date: Tue, 31 Mar 2020 09:43:36 -0400 Message-ID: <2589.1585662216@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier writes: > On Mon, Mar 30, 2020 at 12:48:51PM -0300, Alvaro Herrera wrote: >> On 2020-Mar-30, Tom Lane wrote: >>> I wonder if we should force reuse_previous to false if there's >>> no o_conn, rather than fixing this stuff piecemeal. >> That was my impression too. > Good point. What do you think about the attached then? WFM. regards, tom lane