Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc6J8-0001QW-Ej for pgsql-bugs@arkaria.postgresql.org; Tue, 14 Mar 2023 15:11:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pc6J7-0002gf-79 for pgsql-bugs@arkaria.postgresql.org; Tue, 14 Mar 2023 15:11:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc6J6-0002gU-VL for pgsql-bugs@lists.postgresql.org; Tue, 14 Mar 2023 15:11:20 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc6J4-00020M-PI for pgsql-bugs@lists.postgresql.org; Tue, 14 Mar 2023 15:11:20 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 32EFBGkZ2616371; Tue, 14 Mar 2023 11:11:16 -0400 From: Tom Lane To: Richard Guo cc: Tomas Vondra , PostgreSQL mailing lists Subject: Re: ERROR: PlaceHolderVar found where not expected In-reply-to: References: <2474960.1678764751@sss.pgh.pa.us> <2475647.1678765184@sss.pgh.pa.us> Comments: In-reply-to Richard Guo message dated "Tue, 14 Mar 2023 14:08:23 +0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2616369.1678806676.1@sss.pgh.pa.us> Date: Tue, 14 Mar 2023 11:11:16 -0400 Message-ID: <2616370.1678806676@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Richard Guo writes: > Yes agreed. The pull_var_clause precheck is not necessary considering > we would match the 'clause_expr' to StatisticExtInfo expressions with > equal(). +1 to remove it. Done that way. regards, tom lane