From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andrey Borodin <x4mmm@yandex-team.ru>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Adam Scott <adam.c.scott@gmail.com>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16122: segfault pg_detoast_datum (datum=0x0) at fmgr.c:1833
 numrange query
In-reply-to: <20200109054545.GL2251@paquier.xyz>
References: 
 <CA+s62-Mnj-x8_ZXh7tBVU3WJ3cKUsUL2HAp2YaJSXQPw1iypFw@mail.gmail.com>
 <20191119014827.GC1614@paquier.xyz>
 <20191119103813.xnsloisoxkwrxoim@development>
 <20191119114056.GA516103@paquier.xyz> <20191210053815.GI72921@paquier.xyz>
 <837E8CEE-FFF3-497C-B7C2-37BB42FAF2C5@yandex-team.ru>
 <DE43C854-F3BD-4247-93F3-2774B643445C@yandex-team.ru>
 <5794.1578342514@sss.pgh.pa.us> <20200107063907.GF2386@paquier.xyz>
 <23459.1578409687@sss.pgh.pa.us> <20200109054545.GL2251@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Thu, 09 Jan 2020 14:45:45 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <26197.1578857968.1@sss.pgh.pa.us>
Date: Sun, 12 Jan 2020 14:39:28 -0500
Message-ID: <26198.1578857968@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Jan 07, 2020 at 10:08:07AM -0500, Tom Lane wrote:
>> I wouldn't mind having a test case if it crashes reliably, but it
>> doesn't for me.

> Ah, OK.  That makes sense.  If you don't wish to keep the test around
> in core, that's fine to me.  I may keep that into one of my own repos
> just for history's sake.

OK.  Hearing no further comments, I made another pass over the code
(improved some comments, added one more guard against silly subdiff
results) and pushed this.

			regards, tom lane