From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
cc: Pavel Borisov <pashkin.elfe@gmail.com>,
        Alexander Lakhin <exclusion@gmail.com>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17847: Unaligned memory access in ltree_gist
In-reply-to: 
 <CAPpHfdt7Jonzoh763XbP0idPUPp5JaTj2rtQotXLsrr0+Dqp-A@mail.gmail.com>
References: <17847-171232970bea406b@postgresql.org>
 <3966266.1678995315@sss.pgh.pa.us>
 <CAPpHfds=s6CmMzB1pO2UX9QnUvz6nOWofdnK84NXPQdVp0VWEw@mail.gmail.com>
 <365d1917-f5b7-ff20-2d0b-8d501cee5434@gmail.com>
 <CAPpHfdvvB1-tGha_CXeN5ojWZ48=C77sSrVkgSLLFCVMfv0s1Q@mail.gmail.com>
 <CALT9ZEF9RnRM9gkE6J_GLN8XTdQ3gZw=c6CHyZY5VueAs4T0PA@mail.gmail.com>
 <CAPpHfduJEJbeRGm-VgeyPAzNzC6oc8u+WNqfcZgWnXPUo6F6Dg@mail.gmail.com>
 <CALT9ZEHCN686xmRGorzoAcAJfE6NnNwDuAE=TxAe1tcp5aQTiA@mail.gmail.com>
 <CAPpHfdt7Jonzoh763XbP0idPUPp5JaTj2rtQotXLsrr0+Dqp-A@mail.gmail.com>
Comments: In-reply-to Alexander Korotkov <aekorotkov@gmail.com>
	message dated "Tue, 18 Apr 2023 14:43:38 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2654442.1681830401.1@sss.pgh.pa.us>
Date: Tue, 18 Apr 2023 11:06:41 -0400
Message-ID: <2654443.1681830401@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2654443.1681830401%40sss.pgh.pa.us>
Precedence: bulk

Alexander Korotkov <aekorotkov@gmail.com> writes:
> LGMT.  I'm going to push v3 unless there are more comments.

I think this reads pretty awkwardly:

+ERROR:  siglen value must be integer-aligned
+DETAIL:  Valid are int-aligned values between "4" and "2024".

The DETAIL message's grammar seems a bit off.  Also, this is confusing the
range limitation with the alignment requirement.  How about just saying

ERROR:  siglen value must be a multiple of 4

and leaving out-of-range cases to be handled by the existing check?

			regards, tom lane