Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIk3T-00075R-15 for pgsql-bugs@arkaria.postgresql.org; Tue, 23 Apr 2019 01:17:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hIk3Q-0007vO-I6 for pgsql-bugs@arkaria.postgresql.org; Tue, 23 Apr 2019 01:17:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIk3P-0007vH-Uy for pgsql-bugs@lists.postgresql.org; Tue, 23 Apr 2019 01:17:00 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIk3N-0004Me-OU for pgsql-bugs@lists.postgresql.org; Tue, 23 Apr 2019 01:16:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rDMFPmm9Wuwu8KxoQ8iAAsSHvggIY+7VtmBKgTLh/PY=; b=OJETdprUm3OdKdmCUUl0csdKyX 86AkkVlm6HfEwMy/KIepT2ex0PAaGBGBg1bik8Fkv0A/J6qQ9xA3FmmAmzV5qpOUNkw4LJsxBmgF2 rvSbxW5PQ0MwhUsFOhF9ZOZrzmhvgjCgqolXXdTSHRth2D9ymVEDusDFrAcxTnFidiitpphBz0uKE TP6mB8qSof3mb9DObBLt/ChAhzze9n2n0DykMjAMXrur4xuYt6vYQwAvfsQN4OE1jD4PJaf3rk6hd dkadKKhW/Lo7+m8iPamu7ndmY0F6IBxDcj/Qa8nugKYWGr6Ex4TDr5cA4pI//PV803NoeVR4eiDcS VBzubujw==; Received: from pool-96-250-83-19.nycmny.fios.verizon.net ([96.250.83.19] helo=Ph33r-Retina.home) by meldrar.postgresql.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIk3K-0005un-PG; Tue, 23 Apr 2019 01:16:57 +0000 Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords To: Tom Lane , Michael Paquier Cc: pgsql-bugs@lists.postgresql.org, Stephen Frost References: <016deb6b-1f0a-8e9f-1833-a8675b170aa9@postgresql.org> <4240a41f-a957-fd7d-7c24-31683f259b9d@postgresql.org> <20190422015051.GA3433@paquier.xyz> <3033.1555940554@sss.pgh.pa.us> <5a93333c-dde6-ee52-f870-4dccfc50eb6f@postgresql.org> <30284.1555972921@sss.pgh.pa.us> <15140775-08c3-45bd-6dab-fdcd290d1bf0@postgresql.org> <20190423010142.GE2712@paquier.xyz> <10698.1555981849@sss.pgh.pa.us> From: "Jonathan S. Katz" Openpgp: preference=signencrypt Autocrypt: addr=jkatz@postgresql.org; keydata= mQINBFtShwABEAC7PNHDUOTYuifpUCk23KqfxdQQkn4nkoxOXRK0+rAj36FiwqGB4TJFuOVZ sDFAEiSlC8Jt4y5Cs7B5tetT8JNd2cs6zp/udMJJDz9d65O9PDpdlMgAmIiTzpLlSdx8FG56 DTksaDv1d8j3cTJPSE4/fWSxqzA7o3Y9UuL7atZPrzfImgpRKs0of7elIHwOa8GucjyhYqcR h60wFBJc2KXqQdDYRTZy43DSnY/0VNc0omiH355fustvpm+m5HjD3w7qZyfN3fpKJpnX1LCF f3MnPHaDGITIYGRCBXvf0UqUtD6OEVWPv2C2gyqWMIpWmZTOgDufltKyIByKBoS9x0PlFkij 04X3KODCngt+N8Ssc9OICc6QSxhjoP48PYPdmiTmkrGuf0LX084wj1xeo1NX7XxZK39F6dTJ DhsIiW0sNS0xMxQHLHG9VLbPjx3SANQBh6BuryPz5ZupW9/TIDmkvprtU/oXfKgtfYm3fxmk EctxbWrEPsFTFPyuMqQu6l+xyQv0s1VLZfjNWaua6H1/gGoIt6kRnn5qMXDVVpijuWkHbv7G ngaQMd258UrrOEHnnjzhQ7jxMWV9D+emxbAtlIxnYvCWlV4IwAQhEHfvudqYaIY3hNWrvQ6H GB2KXoTZYN9g5djm14/5nj1IU5zOcovkjJnKhoo9iStnpFF2cwARAQABtCdKb25hdGhhbiBT LiBLYXR6IDxqa2F0ekBwb3N0Z3Jlc3FsLm9yZz6JAlQEEwEIAD4CGwMFCQeGH4AFCwkIBwIG FQoJCAsCBBYCAwECHgECF4AWIQT6hLaVryv3miBkP/HxBJxynxxlJwUCW1KJJQAKCRDxBJxy nxxlJwjrD/kBgqsW4QpNpTFw7ifRokZV08CCX4huPBJQ91rrv+UEWlEcotFBHVkYyHnpzARl tcZxhJ9CbFxjniH9cOTty5T/O1yolbOHtZSW8Z8aWV6BVEbjMb+BFxSSLm7RnvJdzQbGCZq2 ZZvfVpB6z3EHYph4KDdVKvMFjoLskxmdS1DE0tE3zTxvoQsi24Q+HOS07kUjs6fsu/WICMfz mgO++AWG9Y0CvN0mm4TkujESzyKM9E5irD+leEMIcddl51Aa2c/VMfBXQbRmpHIgUFTmuHQD CnQih+9i3OJAksDg66SP8a7yiXv5mwvyDi1EfTGVKYR2j+pwyjwnC3oIbvDMmB3uTn2JIjnT iZKPVtAcAylXjubFltihQgNyuShdP4W+kBwZizhUFqUVL8Anx+KoytYmJPfMRFLGuK4obXKq a2ZS3k9KB+H+isOx2nFJOsc7V360Zp1DVaNmuiK10TT6QndShSPaqkJqFtCb6r92rZ9sZM/L 3vtCI4Rrl3Pt1MgtENXupS8gZpJnAYS0j5A1PAZ09r6ANoaeMHspF+5J5fOHeEvqphXr36mm a83Vl1t4orPb0+QmmijmlpseDU63M88Aw5p3c4qj7t8Qr2EZ5zrn7/sFn5wOfbs8Nymxafif QCnlV2vg9p0m7vSk/yLJ4PFZvs52FgqAGRCdRn0s2EC99bkCDQRbUocAARAAv8ho/toQ9DG3 j4f9h9n1aRHr2FlviN2Utpy6L8+dfDggO0geilmkGQOolZ2E60gGfye/kUtF9W3NByO4hxDR 9u6qbOXcdqnuA+cc68EfqlWFJrVtYFxt0h4ElWYOYnIezKthriWch/FY70FGrxs3z8UHOHq5 0wBW433eTvZm90WixBiXEt2v1DgW4Vr3ymfO7Aap/IYyPuE4JzgudAuAl0HKPyNEHWHG1dAb jX1RiCw9gknIDWQOF0B4UAaJctWGVcnZ3A2ULwNGMa1P9ZJlBWf1vcj01aiHMU0yQ7JjJiSp vfm9eM0uSLwRdDrJjyl5ZZqVumjdv2SMNQ8GvYRbEMys3GGDSt9zXgfCSUnPnJfYxjzBHRI6 x44Wfsx8S6hWxepOogCJJ/g67Bk9mY8YV4klWIXDJVOL5jnBC09DbsZG81JaE2QxB8Y7W36Z Mroi9XMxg3s805hQAQUvdG/poU8hN8BWdrnTm/+4eQQp7gDY1ePDmGM6bJC+OHOSnFtR/f+7 0zpKJ10cc7cBygGnl1yR3KjhFyAWUFvP4ZGziKCcpMwXZfe9PGuyA/YOubMphxIn3YsK2wrd faKZYX2GMZCZhMMcvx9IpQrxIJgU+VlwXu/O+Lk10VIPcxPJJwmpdI6HzcS8ZgG6IMcC444X XTuLaP8j2mgcMvYak3ScCykAEQEAAYkCPAQYAQgAJhYhBPqEtpWvK/eaIGQ/8fEEnHKfHGUn BQJbUocAAhsMBQkHhh+AAAoJEPEEnHKfHGUnReMP/RA2UhGQj+G4uBshkRLjpRysabdPqgQB dEBk6wYbio88Wg/2/hgY7UzmDDEwX3sZfQDcrI6+vIobI8uqstZID+WgAAa1JLfChMyVQnSy 0zfWMOABXscc5tGuvFRZvJklTissMFjXUwaREEKp4ZikTvJ/62MCjSdtrUhnPLvoTsHTKRKD ichE+b5A54alwsubTijw12O6N22r5IjZiiSZV0u7dsShyKw+7wCSax9fuBoE43NMYf+dnjMK nerAQYUcZWYMnk+EC8RaqYAxv6XZ2tKx1AkGGktwkQIBwrz9IlDSvJ3LWJ2UIIuLRTdngNgg GIL4zzuUa2F56FqskQIuYMaNETk6LYfalBDQ6TVLAcgCPQxp4k4i/PRsZ3lZ2ZhRHRYciOvm kp+I6EfHwllQpYrWs1thluBGqlJSVJgKl0IOFvKLsQ6KKfqzAwh6FxrO5qajp4viNIgtWoFw O5Bp0jgFTbH2OrMWIRfUdUCH1Djbuo65svhNj7FNsQVYzHDI+Nd1I/LOBoPc3UorRMF2M4JV kUR7skOHWUbPTSNUr7qc14NSMY3PKjGeVGAsBVHBPvmRx/Ss2tW/TpJWpxg4pmquFQSXuaYh Yf4FN8Sxy320pcr+FqN8AhZkYJcNY82OTtR5VEKRC/mYcyq61qXIKqngydn79bJjGxHipxyF FmEC Message-ID: <265876b8-1a72-89cd-bdcf-e641d93e166c@postgresql.org> Date: Mon, 22 Apr 2019 21:16:49 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <10698.1555981849@sss.pgh.pa.us> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6J8klL7z1HAt8I4HM4i9a1p1T4x4DcriO" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6J8klL7z1HAt8I4HM4i9a1p1T4x4DcriO Content-Type: multipart/mixed; boundary="D2XhUVU9yWj26ba3dKdMajquxvBBihKU3"; protected-headers="v1" From: "Jonathan S. Katz" To: Tom Lane , Michael Paquier Cc: pgsql-bugs@lists.postgresql.org, Stephen Frost Message-ID: <265876b8-1a72-89cd-bdcf-e641d93e166c@postgresql.org> Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords References: <016deb6b-1f0a-8e9f-1833-a8675b170aa9@postgresql.org> <4240a41f-a957-fd7d-7c24-31683f259b9d@postgresql.org> <20190422015051.GA3433@paquier.xyz> <3033.1555940554@sss.pgh.pa.us> <5a93333c-dde6-ee52-f870-4dccfc50eb6f@postgresql.org> <30284.1555972921@sss.pgh.pa.us> <15140775-08c3-45bd-6dab-fdcd290d1bf0@postgresql.org> <20190423010142.GE2712@paquier.xyz> <10698.1555981849@sss.pgh.pa.us> In-Reply-To: <10698.1555981849@sss.pgh.pa.us> --D2XhUVU9yWj26ba3dKdMajquxvBBihKU3 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/22/19 9:10 PM, Tom Lane wrote: > Michael Paquier writes: >> There is no point for the second strlen() check, as strspn does the >> same work. >=20 > Um, no --- the strspn call will count the number of bytes of hex > data, but without also checking strlen, you don't know that there's > not non-hex trailing junk. +1; that's why I left the comparison in. (e.g. "md512345678901234567890123456789012zzz" would pass without strlen)= =2E Jonathan --D2XhUVU9yWj26ba3dKdMajquxvBBihKU3-- --6J8klL7z1HAt8I4HM4i9a1p1T4x4DcriO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE+oS2la8r95ogZD/x8QSccp8cZScFAly+Z4IACgkQ8QSccp8c ZSd7Tw/+JiFvryliUCGMR+5CBJ5UAKA8WS87JFVmHMjMrcySW+ovx+0KcZ6Wpj3V F2sZ7EG+fkjlGmsp1MtWZqx26MWgpBuZ8PQrs1atA2/yXVK1zYB3qj9UFhliG4pk v9K/ik3l+GnOfVgdhi/K9AJzPVrrupTnwSn1QhXWwKd/55506RdfBLR5kdvj8vJL dAO3uYV6VqMedMzi/U4bFJFbmXx9x33vc8/QkIcbfkbvNwFbY8nCGk/C3oEEifBr fAca9kieUWd5huYvIwppLglgHCFYMLRWUWh36aWYE1+3pihNuKbxvpp7k7sOSBCO e+JIDBqK/SlzbBDq4xKqHGmM2YSp9N0Z7TbfOBsV1skwRifN3nhJ2VZ6axA6YAXL siJ5zoBC5qVVY+80fjywQSpAjTMSmo9fd/AIaWhV3/il+WVUYijlEIVGuLj1SaJI JzmkQVemQIMoiiJRiRpkNxPJL62609wVSDsM4gGILVUrqKA6Vx18pqUhSGv5GJEv AofaGNSLEg3EABRX+OvwHHgG/Lbvvt/6u44CesMkiN+5WIsw2onRh2mJr1AV01Wm oHn3DEJxtJ2y3Up4MIMMILGd/MRCwIrIPwbbn3QYH9zTbDwPei9Q/Vhf7jmPorE+ vrJu/21CrJVIbDlDSXpkEDvqElFYDeCw+yfbO8gXR3+hCoATsUA= =C/8f -----END PGP SIGNATURE----- --6J8klL7z1HAt8I4HM4i9a1p1T4x4DcriO--