Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1r3Hcb-002vAp-37
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Nov 2023 15:16:05 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1r3HcZ-0008IK-IA
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Nov 2023 15:16:03 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1r3HcZ-0008IB-8h
	for pgsql-hackers@lists.postgresql.org; Wed, 15 Nov 2023 15:16:03 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1r3HcS-005iKz-Hp
	for pgsql-hackers@lists.postgresql.org; Wed, 15 Nov 2023 15:16:01 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 3AFFFtJa2661436;
	Wed, 15 Nov 2023 10:15:55 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Aleksander Alekseev <aleksander@timescale.com>
cc: pgsql-hackers@lists.postgresql.org, James Keener <jim@jimkeener.com>
Subject: Re: BUG #18097: Immutable expression not allowed in generated at
In-reply-to: 
 <CAJ7c6TN3myMtC4_r+68=a_z60NkBipowWyX76e1j_7Vp05TPnA@mail.gmail.com>
References: <18097-ebb179674f22932f@postgresql.org>
 <CAKFQuwZW=wyr_Nfi8Ww+U-jxdh4tvztvMjT23iv2Ly+Oc0n5eQ@mail.gmail.com>
 <118FF128-C9CA-490C-8E67-65888EE8283F@jimkeener.com>
 <1887197.1694189299@sss.pgh.pa.us> <2250243.1694287087@sss.pgh.pa.us>
 <2275069.1694300202@sss.pgh.pa.us>
 <CAJ7c6TNNG_x8enNdhqmGdg_9A0fNa0LBadecBkuHc-=a7YqaFg@mail.gmail.com>
 <2502479.1699984134@sss.pgh.pa.us>
 <CAJ7c6TN3myMtC4_r+68=a_z60NkBipowWyX76e1j_7Vp05TPnA@mail.gmail.com>
Comments: In-reply-to Aleksander Alekseev <aleksander@timescale.com>
	message dated "Wed, 15 Nov 2023 14:44:09 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2661434.1700061355.1@sss.pgh.pa.us>
Date: Wed, 15 Nov 2023 10:15:55 -0500
Message-ID: <2661435.1700061355@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2661435.1700061355%40sss.pgh.pa.us>
Precedence: bulk

Aleksander Alekseev <aleksander@timescale.com> writes:
>>> Oh no! We encountered one of the most difficult problems in computer
>>> science [1].

>> Indeed :-(.  Looking at it again this morning, I'm thinking of
>> using "contain_mutable_functions_after_planning" --- what do you
>> think of that?

> It's better but creates an impression that the actual planning will be
> involved.

True, but from the perspective of the affected code, the question is
basically "did you call expression_planner() yet".  So I like this
naming for that connection, whereas something based on "transformation"
doesn't really connect to anything in existing function names.

			regards, tom lane