From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Janes <jeff.janes@gmail.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: BUG #16345: ts_headline does not find phrase matches correctly
In-reply-to: 
 <CAMkU=1zqTNcxWzFwuRMhJpc5d_q2+j3TbFXiee4PmuGLP0LVnA@mail.gmail.com>
References: <16345-2e0cf5cddbdcd3b4@postgresql.org>
 <25072.1586401341@sss.pgh.pa.us>
 <CAMkU=1zqTNcxWzFwuRMhJpc5d_q2+j3TbFXiee4PmuGLP0LVnA@mail.gmail.com>
Comments: In-reply-to Jeff Janes <jeff.janes@gmail.com>
	message dated "Thu, 09 Apr 2020 14:39:41 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <26694.1586460589.1@sss.pgh.pa.us>
Date: Thu, 09 Apr 2020 15:29:49 -0400
Message-ID: <26695.1586460589@sss.pgh.pa.us>
Precedence: bulk

Jeff Janes <jeff.janes@gmail.com> writes:
> I am getting a compiler warning, both with and without --enable-cassert.

> wparser_def.c: In function 'prsd_headline':
> wparser_def.c:2530:2: warning: 'pose' may be used uninitialized in this
> function [-Wmaybe-uninitialized]
>   mark_fragment(prs, highlightall, bestb, beste);
>   ^
> wparser_def.c:2384:6: note: 'pose' was declared here
>   int   pose,

I see it too, now that I try a different compiler version.  Will fix.

> It makes no sense to me that pose could be used uninitialized on a line
> that doesn't use pose at all, so maybe it is a compiler bug or something.

It looks like the compiler is doing aggressive inlining, which might
have something to do with the crummy error report placement.  Notice
that this isn't inside 'prsd_headline' at all, so far as the source code
is concerned.

			regards, tom lane