From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Peter Eisentraut <peter@eisentraut.org>, Bruce Momjian <bruce@momjian.us>,
        walther@technowledgy.de, Christophe Pettus <xof@thebuild.com>,
        Andrew Dunstan <andrew@dunslane.net>,
        PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>,
        Robert Haas <robertmhaas@gmail.com>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be
 loaded
In-reply-to: 
 <CA+hUKGKU_0hmqem_EmAwePjVtMrjZNyNN0niUdBhuABajRwyhw@mail.gmail.com>
References: 
 <CA+hUKGK2cSx3dveMqBD+E9N=zJ0WawBcbk_jnPqmdWBM0DT_3Q@mail.gmail.com>
 <477fa513-6bf0-456d-8d24-1e22a19df671@technowledgy.de>
 <ZfrmN4WHuJgD95fw@momjian.us>
 <CA+hUKGJzC4rr2Yr=QZyx9W83Wv=TVJHndKF1anjNLNXVUM7TqQ@mail.gmail.com>
 <f98cd8de-1c66-491a-8409-e62c09932080@technowledgy.de>
 <36690fcf-f0c8-4d60-af49-6a7efa0e2b14@technowledgy.de>
 <CA+hUKGJAkTZUa9JGr-zsadaqsN=K0P71t-1L2t2=MQFDMc4GuQ@mail.gmail.com>
 <ZfzLsiXbguTDatiZ@momjian.us>
 <a2463df1-be45-4a76-b90f-7676d778e7b1@technowledgy.de>
 <Zf2JU0_GDdbeBm5j@momjian.us> <Zf3fnKpHIGpe5mOi@momjian.us>
 <443430b4-0c10-49f3-8c8a-e5e76602f309@eisentraut.org>
 <CA+hUKGKU_0hmqem_EmAwePjVtMrjZNyNN0niUdBhuABajRwyhw@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Tue, 26 Mar 2024 11:54:59 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2712380.1711408552.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 25 Mar 2024 19:15:52 -0400
Message-ID: <2712381.1711408552@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2712381.1711408552%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> On Tue, Mar 26, 2024 at 11:46=E2=80=AFAM Peter Eisentraut <peter@eisentr=
aut.org> wrote:
>> What determines which variables require this treatment?

> I had originally proposed to avoid anything beginning "LD_" but Tom
> suggested being more specific.  I doubt LD_PRELOAD can really hurt you
> though (the linker probably only needs the value at the start by
> definition, not at later dlopen() time (?)).

Oh, good point.  So we could simplify the patch by only looking for
LD_LIBRARY_PATH.

			regards, tom lane