From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: Daniel Gustafsson <daniel@yesql.se>,
        Nathan Bossart <nathandbossart@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        =?UTF-8?Q?Matthias_H=C3=B6rmann?= <matthias.hoermann@saltation.com>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19042: Option --help not recognized at the end of command
 line in pg_restore
In-reply-to: <cbdf8bd4-6296-46c7-bd02-9c08645257b8@eisentraut.org>
References: <19042-347869ae37c993f4@postgresql.org>
 <144DDCC5-8EB1-4AA2-91FB-36916898A86F@yesql.se>
 <aLgrFiwZcwCw1giD@saltation.com> <804476.1756911473@sss.pgh.pa.us>
 <53lkszuko3qwk4sn6mxz5dl6yahkosrksm3pcxjikcuxj3vssq@jwzipa3ikold>
 <513f6b2f-e6be-423d-aad6-4ab58988278b@eisentraut.org>
 <C3707C55-9C54-47FB-90FB-E47A36F7D721@yesql.se> <aPlLZR_7tTa7WxOg@nathan>
 <B8FA8D64-5575-41F1-9F3B-DF603495309A@yesql.se>
 <cbdf8bd4-6296-46c7-bd02-9c08645257b8@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Wed, 29 Oct 2025 16:24:46 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2752563.1761752918.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 29 Oct 2025 11:48:38 -0400
Message-ID: <2752564.1761752918@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2752564.1761752918%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> On 25.10.25 00:26, Daniel Gustafsson wrote:
>> While hacking on this it seemed like a good idea to move to using progn=
ame
>> consistently, and reduce scope in some places from global variables, bu=
t
>> looking at it now I'm less convinced.  At the very least it should be r=
ipped
>> out into its own patch but for now those changes are left in there.

> The --version outputs intentionally do not use progname, so that you get=
 =

> a proper identification of the program and version independent of what =

> the binary might be called.  Please don't change that.

Hmm, that's important institutional knowledge that should be captured
somewhere.

			regards, tom lane