From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Gavin Flower <GavinFlower@archidevsys.co.nz>,
        Noah Misch <noah@leadboat.com>, neverov.max@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
In-reply-to: <2753264.1619568545@sss.pgh.pa.us>
References: <20210427234438.GA22943@alvherre.pgsql>
 <2753264.1619568545@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Tue, 27 Apr 2021 20:09:05 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2761424.1619581390.1@sss.pgh.pa.us>
Date: Tue, 27 Apr 2021 23:43:10 -0400
Message-ID: <2761425.1619581390@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2761425.1619581390%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Hm.  We actually document PQprint.  While the other two entry points
> in that file aren't documented, they are listed in exports.txt,
> which means somebody *could* be calling them.  I think we'd at least
> have to go through a long deprecation period before we could consider
> removing them.

Meanwhile, returning to the point at hand in this thread: AFAICS
from a quick review of the git logs, the last intentional changes
of user-visible behavior in fe-print.c were more than 20 years ago.
Since then it's only seen in-passing bug fixes, such as libpq-wide
fixes of signal handling.

So, to the extent that this code has any use at all it's for
legacy applications.  I don't think we should be making random
changes in its behavior for at-best-weak reasons.

In short, I'm now a vote to revert every single bit of 5da9868ed.

			regards, tom lane