Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7NE4-0004Pl-4k for pgsql-bugs@arkaria.postgresql.org; Tue, 11 Jan 2022 19:54:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n7NE2-0002Az-8p for pgsql-bugs@arkaria.postgresql.org; Tue, 11 Jan 2022 19:54:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7NE2-0002Aq-0g for pgsql-bugs@lists.postgresql.org; Tue, 11 Jan 2022 19:54:34 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7NDy-0006qU-Vb for pgsql-bugs@lists.postgresql.org; Tue, 11 Jan 2022 19:54:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 20BJsSAT2761802; Tue, 11 Jan 2022 14:54:28 -0500 From: Tom Lane To: Peter Geoghegan cc: Klaudie Willis , PostgreSQL mailing lists Subject: Re: When Update balloons memory In-reply-to: References: <3484560.1638889073@sss.pgh.pa.us> <189763.1639437451@sss.pgh.pa.us> <261065.1639497535@sss.pgh.pa.us> <377324.1639510427@sss.pgh.pa.us> Comments: In-reply-to Peter Geoghegan message dated "Tue, 11 Jan 2022 11:45:19 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2761800.1641930868.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Tue, 11 Jan 2022 14:54:28 -0500 Message-ID: <2761801.1641930868@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Geoghegan writes: > I haven't made the code use pull_varnos(), which you suggested back in > December. It looks like it would be tricky to do that from the > executor, since pull_varnos() has a PlannerInfo* argument. That has > been the case since your commit 55dc86eca7 from January 2021, "Fix > pull_varnos' miscomputation of relids set for a PlaceHolderVar". > Please advise. Pass NULL for that, per 6867f963e: https://git.postgresql.org/gitweb/?p=3Dpostgresql.git;a=3Dcommitdiff;h=3D6= 867f963e#patch2 We'd have to back-patch that bit, but I don't see any problem with doing so. regards, tom lane