Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rDmtW-0038dH-Uw for pgsql-bugs@arkaria.postgresql.org; Thu, 14 Dec 2023 14:40:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rDmtT-008vDU-NQ for pgsql-bugs@arkaria.postgresql.org; Thu, 14 Dec 2023 14:40:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rDmtT-008vDM-F8 for pgsql-bugs@lists.postgresql.org; Thu, 14 Dec 2023 14:40:55 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rDmtQ-00ByiO-AW for pgsql-bugs@lists.postgresql.org; Thu, 14 Dec 2023 14:40:54 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 3BEEempj2780889; Thu, 14 Dec 2023 09:40:48 -0500 From: Tom Lane To: Julien Rouhaud cc: rekgrpth@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18248: Expression is always zero In-reply-to: References: <18248-4250c882e2a8b8f6@postgresql.org> Comments: In-reply-to Julien Rouhaud message dated "Thu, 14 Dec 2023 12:10:36 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2780887.1702564848.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 14 Dec 2023 09:40:48 -0500 Message-ID: <2780888.1702564848@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Julien Rouhaud writes: > On Thu, Dec 14, 2023 at 05:32:49AM +0000, PG Bug reporting form wrote: >> The value of expression 'thistimecnt >> 31 >> 31 >> 2' (in >> src/timezone/zic.c) is zero regardless of the value of the left operand > Note that this is code imported as-is from upstream IANA tzcode, so we w= ouldn't > make any change ourself. > Looking at their git history they added it to remove some theoretical in= t > limits: > https://github.com/eggert/tz/commit/cc8aec6ecb1ecc3099f173e2bca9785ae835= 9c03 Yeah, the tzcode crew have a wider range of (possibly theoretical) target systems in mind than we do. They probably won't think this is a bug, and we're unlikely to diverge from whatever they do. regards, tom lane