From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
cc: Daniel Gustafsson <daniel@yesql.se>, mb.alzouabi@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18245: pg_restore accepts same output file name as input
 file name
In-reply-to: <ZXsTb3HttMOyyBox@jrouhaud>
References: <18245-eed25801b2d599c9@postgresql.org>
 <E7AEB7F8-BB3E-403F-ACDB-E06AF4E37861@yesql.se> <ZXsTb3HttMOyyBox@jrouhaud>
Comments: In-reply-to Julien Rouhaud <rjuju123@gmail.com>
	message dated "Thu, 14 Dec 2023 15:38:39 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2781743.1702565401.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 14 Dec 2023 09:50:01 -0500
Message-ID: <2781744.1702565401@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2781744.1702565401%40sss.pgh.pa.us>
Precedence: bulk

Julien Rouhaud <rjuju123@gmail.com> writes:
> On Wed, Dec 13, 2023 at 09:44:26AM +0100, Daniel Gustafsson wrote:
>> Something like the attached (untested) sketch should be enough I think.

> I'm wondering if it would be worth adding some canonicalize_path() calls=
 while
> at it,  ISTM that such mistakes are likely to happen when invoking pg_re=
store
> manually, so having slightly different wording for the exact same file w=
ouldn't
> surprising.

I'm a little dubious about the value of this; but if we're going to do
it, comparing post-canonicalize_path strings does seem like the right
way.

			regards, tom lane