Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1me0Br-0003iV-6g
	for pgsql-bugs@arkaria.postgresql.org; Fri, 22 Oct 2021 19:26:55 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1me0Bq-0008JL-5A
	for pgsql-bugs@arkaria.postgresql.org; Fri, 22 Oct 2021 19:26:54 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1me0Bp-0008JB-TX
	for pgsql-bugs@lists.postgresql.org; Fri, 22 Oct 2021 19:26:53 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1me0Bn-0003ui-Mf
	for pgsql-bugs@lists.postgresql.org; Fri, 22 Oct 2021 19:26:52 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 19MJQnOm2818928;
	Fri, 22 Oct 2021 15:26:49 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Neil Chen <carpenter.nail.cz@gmail.com>
cc: "Bossart, Nathan" <bossartn@amazon.com>,
        Masahiko Sawada <sawada.mshk@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        "Boris P. Korzun" <drtr0jan@yandex.ru>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES
In-reply-to: <2008944.1634680714@sss.pgh.pa.us>
References: 
 <CAA3qoJnr2+1dVJObNtfec=qW4Z0nz=A9+r5bZKoTSy5RDjskMw@mail.gmail.com>
 <8261632200581@mail.yandex.ru>
 <CAA3qoJ=f6jZAkkfwH+rtH_8C9z-nfcgNFYZnGYxVdBjz7Vkhig@mail.gmail.com>
 <CAD21AoBrCbjiJt3OCDQCLrM6OQOxjV9cAyM6bn4=SjHq0konBQ@mail.gmail.com>
 <CAD21AoC+m46JEsFE2d6JQuPuNN5ODj1vpZ3z2HtPdn+HFDJfdg@mail.gmail.com>
 <721942.1634180151@sss.pgh.pa.us>
 <CAD21AoAUCNCo77LJLAFGEkhtgruMpzPD153SC7dY7TyahvM_Fg@mail.gmail.com>
 <YWfh9O/36r+GlgNB@paquier.xyz>
 <CAD21AoDRg1E7AEM_5ifyjFbQ71J303OHA-R1HjzqC0FT306dKQ@mail.gmail.com>
 <AB89F451-ED7F-4FA6-ADF8-F8132220D6A2@amazon.com>
 <CAD21AoArNPsNKYE1b-oURYonUA7Zo-kaq-u661uWcZqTURb48A@mail.gmail.com>
 <1737876.1634613552@sss.pgh.pa.us>
 <CAD21AoC5qNd8psDS4x792DCeuC3xcBmq6Bjrkj8_P1sAscJz4Q@mail.gmail.com>
 <1951182.1634673234@sss.pgh.pa.us>
 <2C411167-8492-497B-A110-81E7081B1B0E@amazon.com>
 <2008944.1634680714@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Tue, 19 Oct 2021 17:58:34 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2818926.1634930809.1@sss.pgh.pa.us>
Date: Fri, 22 Oct 2021 15:26:49 -0400
Message-ID: <2818927.1634930809@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/2818927.1634930809%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> [ pokes at it some more... ]  Yeah, I just didn't have my head screwed
> on straight.  We need the global entries to be dumped as deltas from
> the proper object-type-specific ACL, while the non-global ones should be
> dumped as grants only, which can be modeled as a delta from an empty
> ACL.  So the patch should be good as given (though maybe the comment
> needs more work to clarify this).  Sorry for the noise.

This was blocking some other work I'm doing on pg_dump, so I rewrote
the comment some more and pushed it.

			regards, tom lane