Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uT62e-00HNIX-SO for pgsql-bugs@arkaria.postgresql.org; Sat, 21 Jun 2025 21:46:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uT62Z-009U3k-UT for pgsql-bugs@arkaria.postgresql.org; Sat, 21 Jun 2025 21:46:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uT62Z-009U20-L7 for pgsql-bugs@lists.postgresql.org; Sat, 21 Jun 2025 21:46:24 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uT62X-003NKl-2Y for pgsql-bugs@lists.postgresql.org; Sat, 21 Jun 2025 21:46:23 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 55LLkIr22831376; Sat, 21 Jun 2025 17:46:18 -0400 From: Tom Lane To: Dmitry Kovalenko cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c) In-reply-to: <5ff4b743-b9ab-4406-92db-d6e00be2b301@postgrespro.ru> References: <18960-09cd4a5100152e58@postgresql.org> <1181606.1750280943@sss.pgh.pa.us> <2790652.1750536063@sss.pgh.pa.us> <5ff4b743-b9ab-4406-92db-d6e00be2b301@postgrespro.ru> Comments: In-reply-to Dmitry Kovalenko message dated "Sat, 21 Jun 2025 23:42:42 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2831374.1750542378.1@sss.pgh.pa.us> Date: Sat, 21 Jun 2025 17:46:18 -0400 Message-ID: <2831375.1750542378@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Dmitry Kovalenko writes: > As I understand, you have leaks of 'res' when (PQresultStatus(res) != > status) I don't think we really care about leaks when pg_fatal is called. (If we do, there are a lot of others to worry about.) > I spent the some time to fix a leaks in tests and PG itself here: > https://github.com/dmitry-lipetsk/postgres/commits/D20250617_001-pg_master/ Ah, I did not know you were working on this. Perhaps you can merge what we've done. regards, tom lane