Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j5kzq-0003M4-WC for pgsql-bugs@arkaria.postgresql.org; Sun, 23 Feb 2020 06:44:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j5kzn-0004ZW-T7 for pgsql-bugs@arkaria.postgresql.org; Sun, 23 Feb 2020 06:44:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j5kzn-0004ZP-Kn for pgsql-bugs@lists.postgresql.org; Sun, 23 Feb 2020 06:44:07 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j5kzi-0002cg-Je for pgsql-bugs@lists.postgresql.org; Sun, 23 Feb 2020 06:44:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 01N6hQw1028474; Sun, 23 Feb 2020 01:43:27 -0500 From: Tom Lane To: sunqiankun@highgo.com cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16273: InitDB Memory leak In-reply-to: <16273-9ebc6c641602e0a5@postgresql.org> References: <16273-9ebc6c641602e0a5@postgresql.org> Comments: In-reply-to PG Bug reporting form message dated "Sun, 23 Feb 2020 06:05:48 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28472.1582440206.1@sss.pgh.pa.us> Date: Sun, 23 Feb 2020 01:43:26 -0500 Message-ID: <28473.1582440206@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk PG Bug reporting form writes: > when i read the code in src/bin/initdb/initdb.c. > At the function: set_info_version, we use pg_strdup to malloc memory, but > we don't free it. There are lots of minor memory leaks in initdb. We don't really care that much, because the program executes over a fixed set of data and then terminates. regards, tom lane