Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1hz9YM-0006ub-4H
	for pgsql-bugs@arkaria.postgresql.org; Sun, 18 Aug 2019 01:00:14 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1hz9YI-0008GX-H5
	for pgsql-bugs@arkaria.postgresql.org; Sun, 18 Aug 2019 01:00:10 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hz9YI-0008GQ-6M
	for pgsql-bugs@lists.postgresql.org; Sun, 18 Aug 2019 01:00:10 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hz9YB-00015K-Fr
	for pgsql-bugs@lists.postgresql.org; Sun, 18 Aug 2019 01:00:08 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x7I0xujL028481;
	Sat, 17 Aug 2019 20:59:56 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Dilip Kumar <dilipbalaut@gmail.com>, jungleboogie0@gmail.com,
        pgsql-bugs@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared
 identifier 'FD_SETSIZE'
In-reply-to: <20190818001858.ho3ev4z57fqhs7a5@alap3.anarazel.de>
References: <15964-c1753bdfed722e04@postgresql.org>
 <24757.1566073861@sss.pgh.pa.us>
 <20190817210025.v4bblh4lhsxajmlj@alap3.anarazel.de>
 <6402.1566079145@sss.pgh.pa.us>
 <20190817224142.gq57z3cwt7c76dtk@alap3.anarazel.de>
 <20190818001858.ho3ev4z57fqhs7a5@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 17 Aug 2019 17:18:58 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28479.1566089996.1@sss.pgh.pa.us>
Date: Sat, 17 Aug 2019 20:59:56 -0400
Message-ID: <28480.1566089996@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Hm. This made me think: Why is
>                 if (concurrentCons > FD_SETSIZE - 1)
> a useful test / error message?

Good point, it's not.  Subtracting off 10 or so might be reasonable.

> What is the reason that this doesn't use poll() in the first place?

We still support platforms without that, no?  Windows, for one.

			regards, tom lane