From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: anisimow.d@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17462: Invalid memory access in heapam_tuple_lock
In-reply-to: <286748.1649692519@sss.pgh.pa.us>
References: <17462-9c98a0f00df9bd36@postgresql.org>
 <286748.1649692519@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 11 Apr 2022 11:55:19 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <288543.1649693991.1@sss.pgh.pa.us>
Date: Mon, 11 Apr 2022 12:19:51 -0400
Message-ID: <288544.1649693991@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/288544.1649693991%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Reproduced here.  It's surprising that nobody noticed this before,
> because AFAICS the bug is pretty old: it dates to somebody foolishly
> deciding that heap_fetch didn't need its keep_buf argument, which
> evidently happened in v12 (didn't track down the exact commit yet).

The blame falls on Andres' commit 5db6df0c0.  There is no commentary
there justifying this change, and I judge the amount of thought that
went into it by noting that that commit removed the argument without
removing the header comment explaining it.

			regards, tom lane